-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-combobox): add suggestions grouping #3469
Conversation
Enable users to set items to groups. Groups are visually indentified in the suggestions list by group headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ui5-cb-group-item
to the appenddocs tag in ComboBox.js
Add a sample in ComboBox.sample.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we deep test this changed once the value change pull request get merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, someone from @SAP/ui5-webcomponents-topic-rl should approve and we can merge it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ ---------- /
- type "b"
- arrow down - b should be removed
/ ---------- /
- Type "a"
- items gets filtered, but not autocompleted
Overall. looks good, fix these issue and we should be good to go. |
Actually, there is a double focus all the time, but I guess this should be another issue .. |
There is no double focus for me? Please pull the last changes, something is not right. |
lgtm, I think we can merge when someone with rights approve the change |
Enable users to set items to groups. Groups are visually identified in the suggestions list by group headers. For group headers a new component is introduced - ComboBoxGroupItem. The grouping is based on the items order as they are declared in the markup - the items between two group headers are considered to belong to the first one. Fixes: #3371
Enable users to set items to groups. Groups are visually identified in the suggestions list by group headers.
For group headers a new component is introduced - ComboBoxGroupItem. The grouping is based on the items order as they are declared in the markup - the items between two group headers are considered to belong to the first one.
Example - in the code below - the items between the "A" group item and the "Random Group Item" are grouped to the "A" group while the last item belongs to the "Random Group Item Text" group.
Fixes: #3371