Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-card: issues found from mobile exploratory testing iOS #4200

Closed
1 of 4 tasks
kskondov opened this issue Oct 27, 2021 · 1 comment · Fixed by #4462
Closed
1 of 4 tasks

ui5-card: issues found from mobile exploratory testing iOS #4200

kskondov opened this issue Oct 27, 2021 · 1 comment · Fixed by #4462
Assignees
@LidiyaGeorgieva
Labels
1.0 Release Testing bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@kskondov
Copy link
Contributor

kskondov commented Oct 27, 2021 •
edited
Loading

Bug Description

  1. The card with table sample is cut off on the right
  2. In RTL header and subheader doesn't seem to match the direction and padding is not correct

Steps to Reproduce

  1. On iOS device go to https://sap.github.io/ui5-webcomponents/master/playground/components/Card/

Context

  • UI5 Web Components version: master

Log Output / Stack Trace / Screenshots

image
2.
image

Priority

  • Low
  • Medium
  • High
  • Very High
@kskondov kskondov self-assigned this Oct 27, 2021
@kskondov kskondov changed the title ui5-card: issue found from mobile exploratory testing iOS ui5-card: issues found from mobile exploratory testing iOS Oct 27, 2021
@kskondov kskondov removed their assignment Oct 28, 2021
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Dec 6, 2021
@LidiyaGeorgieva
Copy link
Contributor

Regarding the second issue:
The "li" element (inside "ui5-li") doesn't receive its dir="rtl" attribute when the sample loads.
When user clicks on the list item the "dir" appears and the styles are correct.

The behaviour is the same for the List sample in RTL: https://sap.github.io/ui5-webcomponents/playground/components/List/?sap-ui-theme=sap_fiori_3&isrtl=true

Possibly related to #3624

LidiyaGeorgieva added a commit that referenced this issue Dec 9, 2021
@LidiyaGeorgieva
fix(ui5-card): adjust some classes in Playground samples
bbe5a78 
Fixes: #4200
@LidiyaGeorgieva LidiyaGeorgieva mentioned this issue Dec 9, 2021
Merged
2 tasks
georgimkv pushed a commit that referenced this issue Dec 10, 2021
@LidiyaGeorgieva
fix(ui5-card): adjust some classes in Playground samples (#4462)
2a9ed2a 
Fixes: #4200
eshpak pushed a commit to eshpak/ui5-webcomponents that referenced this issue Jan 9, 2022
@LidiyaGeorgieva @eshpak
fix(ui5-card): adjust some classes in Playground samples (SAP#4462)
f04e550 
Fixes: SAP#4200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LidiyaGeorgieva LidiyaGeorgieva

Labels
1.0 Release Testing bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-card): adjust some classes in Playground samples SAP/ui5-webcomponents
2 participants
@kskondov @LidiyaGeorgieva