Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAP]: Needing "search" as an input type for the Input component #7641

Closed
1 task done
emilylian-sap opened this issue Sep 28, 2023 · 2 comments · Fixed by #8980
Closed
1 task done

[SAP]: Needing "search" as an input type for the Input component #7641

emilylian-sap opened this issue Sep 28, 2023 · 2 comments · Fixed by #8980

Comments

@emilylian-sap
Copy link

Is your feature request related to a problem?

On iOS devices, we expect the native keyboard to display the "search" button when the user starts typing in the input. However, currently, it the keyboard shows "return" rather than "search". This is because iOS fails to detect the input as a search input if inputType is not set to "search". ui5wcr Input component does have a "type" property which allows the consumer to define the input type but it only has the options "Email, Number, Passward etc" and "search" is missing from that list.
https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-input--docs
File
The Combobox component also shares the same issue. The input component inside the combobox acts like a search bar so it should have input type "search".
https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-combobox--docs
IMG_4087

Describe the solution you'd like

Adding "search" to the list of input type options for the Input component would allow iOS to detect Input components used as search bars and display the correct button on its keyboard. The input type for the input field inside combobox should be "search", or expose an api to allow consumers to define the input type.

Describe alternatives you've considered

No response

Additional Context

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@MarcusNotheis
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@MarcusNotheis MarcusNotheis transferred this issue from SAP/ui5-webcomponents-react Sep 29, 2023
@elenastoyanovaa elenastoyanovaa self-assigned this Sep 29, 2023
@elenastoyanovaa
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rl ,

An enhancement of the input component is requested by enriching the existing type property with a new type - search. The reason for this request is that a special type of soft keyboard is shown on an iOS device. I checked it and I think that the only difference is the submit button text - for a regular input it is return, for search input it is search.

Could you please look over the feature request?

Kind Regards,
Elena

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

6 participants