Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-color-picker): adjust hue value update when user presses over the main color section #4601

Merged
merged 6 commits into from
Feb 8, 2022
Merged

fix(ui5-color-picker): adjust hue value update when user presses over the main color section #4601

merged 6 commits into from
Feb 8, 2022

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Jan 20, 2022 •
edited
Loading

Fixes: #4540

unazko added 3 commits January 15, 2022 01:23
@unazko
fix(ui5-color-picker): hue value remains unchanged
eceead4 
 - Hue value remains unchanged when users press over the
 main color section, in order to change the color.

Fixes: SAP#4540
@unazko
fix(ui5-color-picker): hue value properly managed
9faba81 
- Hue value doesn't change when user changes the color
trough the main color section.
- Hue value changes accordingly when user changes the color
through the hex input field.

Fixes: SAP#4540
Fixes: SAP#4541
@unazko
code info massages improved
478dd76
@unazko unazko requested review from fifoosid and removed request for fifoosid January 20, 2022 15:28
tsanislavgatev
tsanislavgatev requested changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@tsanislavgatev tsanislavgatev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this refered issue is not fixed yet: #4541
Example:
I input ffffff, then pick red from slider and move the picker to a place different than bottom right corner(white), and then input ffffff again, the color change is not applied.

@unazko unazko changed the title fix(ui5-color-picker): hex value input now properly managed fix(ui5-color-picker): Hue value remains unchanged when user presses over the main color section Jan 24, 2022
@unazko unazko requested a review from tsanislavgatev January 24, 2022 15:51
@unazko
Copy link
Contributor Author

unazko commented Jan 24, 2022

You are right @tsanislavgatev,
I've created a separate PR for the other issue:
#4621
as it feels more suitable now.

tsanislavgatev
tsanislavgatev previously approved these changes Jan 28, 2022
View reviewed changes
ilhan007
ilhan007 previously requested changes Jan 28, 2022
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, as in the other PR I reviewed - please pay attention on the commit message title https://www.conventionalcommits.org/en/v1.0.0/#examples

@unazko unazko changed the title fix(ui5-color-picker): Hue value remains unchanged when user presses over the main color section fix(ui5-color-picker): adjust hue value updates when user presses over the main color section Jan 31, 2022
@unazko unazko changed the title fix(ui5-color-picker): adjust hue value updates when user presses over the main color section fix(ui5-color-picker): adjust hue value update when user presses over the main color section Jan 31, 2022
@ilhan007 ilhan007 dismissed their stale review February 8, 2022 13:09

outdated

@unazko unazko merged commit 4b03374 into SAP:master Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsanislavgatev tsanislavgatev tsanislavgatev approved these changes

@fifoosid fifoosid Awaiting requested review from fifoosid

@a-z-ivanov a-z-ivanov Awaiting requested review from a-z-ivanov

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ColorPicker: color selection behaves weird
3 participants
@unazko @tsanislavgatev @ilhan007