Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPicker: color property not applied once the color slider was used #4541

Closed
1 of 4 tasks
petermuessig opened this issue Jan 2, 2022 · 1 comment · Fixed by #4621
Closed
1 of 4 tasks

ColorPicker: color property not applied once the color slider was used #4541

petermuessig opened this issue Jan 2, 2022 · 1 comment · Fixed by #4621
Assignees
@unazko
Labels
bug This issue is a bug in the code Medium Prio TOPIC B

Comments

@petermuessig
Copy link
Contributor

petermuessig commented Jan 2, 2022 •
edited
Loading

Bug Description

Open the ColorPicker example in the playground and enter the color 0854a0. If you use the top color slider and shift the color e.g. to green and afterwards apply the color 0854a0 again, the color in the selection pane (picker area) stays green but the color shown below displays the expected 0854a0.

Expected Behavior

In any case, when user is changing the color of the color picker, all UI elements should be adopted: either via hex color input, alpha value input or the sliders or the picker. All should be synchronized.

Steps to Reproduce

  1. Go to Color Picker in playground
  2. Enter the color 0854a0 as hex value and press enter
  3. Now select a color in the color slider and re-enter the color 0854a0
  4. The color picker section and the color slider doesn't change anymore

Context

  • UI5 Web Components version: 1.0.1
  • OS/Platform: MacOS
  • Browser: Chrome
  • Affected component: ColorPicker

Screenshots

image

Priority

  • Low
  • Medium
  • High
  • Very High
@terezamch terezamch self-assigned this Jan 4, 2022
@terezamch terezamch added bug This issue is a bug in the code Medium Prio TOPIC B labels Jan 4, 2022
@terezamch
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-b,

There is an issue with the color picker, please refer to the reporters description.

Best regards,
Tereza

@terezamch terezamch removed their assignment Jan 4, 2022
@unazko unazko self-assigned this Jan 6, 2022
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Jan 20, 2022
@unazko
fix(ui5-color-picker): hue value properly managed
9faba81 
- Hue value doesn't change when user changes the color
trough the main color section.
- Hue value changes accordingly when user changes the color
through the hex input field.

Fixes: SAP#4540
Fixes: SAP#4541
@unazko unazko mentioned this issue Jan 20, 2022
Merged
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Jan 24, 2022
@unazko
fix(ui5-color-picker): hex value input change could be triggered on e…
32a820a 
…nter

Fixes: SAP#4541
@unazko unazko mentioned this issue Jan 24, 2022
Merged
@Todor-ads Todor-ads mentioned this issue Feb 10, 2022
Merged
unazko added a commit that referenced this issue Feb 15, 2022
@unazko
fix(ui5-color-picker): enable hex value input change on enter (#4621)
cf45552 
Fixes: #4541
ilhan007 pushed a commit that referenced this issue Mar 18, 2022
@unazko @ilhan007
fix(ui5-color-picker): enable hex value input change on enter (#4621)
b64b724 
Fixes: #4541
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic B Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unazko unazko

Labels
bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Maintenance - Topic B
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-color-picker): enable hex value input change on enter unazko/ui5-webcomponents
3 participants
@petermuessig @terezamch @unazko