Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-progress-indicator): remove disabled property #8683

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

yanaminkova
Copy link
Member

Removes the disabled property of the ui5-progress-indicator.
The Progress Indicator isn't an interactive element, therefore the disabled property make no sense.
Also aria-disabled is deprecated on the progressbar role since ARIA 1.2 .

BREAKING CHANGE: The disabled property of the ui5-progress-indicator is removed.
If you have previously used the disabled property:

<ui5-progress-indicator disabled value="60"></ui5-progress-indicator>

it will no longer work for the component.

Related to #8461, #7887

@yanaminkova yanaminkova mentioned this pull request Apr 8, 2024
@ilhan007 ilhan007 merged commit 5e5c40a into main Apr 8, 2024
9 checks passed
@ilhan007 ilhan007 deleted the pb-remove-disabled branch April 8, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants