Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-progress-indicator): remove disabled property #8683

Merged
merged 1 commit into from
Apr 8, 2024
Merged

refactor(ui5-progress-indicator): remove disabled property #8683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/main/src/ProgressIndicator.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
aria-valuenow="{{validatedValue}}"
aria-valuemax="100"
aria-valuetext="{{valueStateText}}"
aria-disabled="{{_ariaDisabled}}"
aria-label="{{accessibleName}}"
>
<div class="ui5-progress-indicator-bar" part="bar" style="{{styles.bar}}">
Expand Down
12 changes: 0 additions & 12 deletions packages/main/src/ProgressIndicator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,6 @@ class ProgressIndicator extends UI5Element {
@property()
accessibleName!: string;

/**
* Defines whether component is in disabled state.
* @default false
* @public
*/
@property({ type: Boolean })
disabled!: boolean;

/**
* Defines whether the component value is shown.
* @default false
Expand Down Expand Up @@ -195,10 +187,6 @@ class ProgressIndicator extends UI5Element {
return this.valueStateIconMappings()[this.valueState];
}

get _ariaDisabled() {
return this.disabled || undefined;
}

static async onDefine() {
ProgressIndicator.i18nBundle = await getI18nBundle("@ui5/webcomponents");
}
Expand Down
4 changes: 0 additions & 4 deletions packages/main/src/themes/ProgressIndicator.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,6 @@
border-color: var(--_ui5_progress_indicator_border_color_information);
}

:host([disabled]) .ui5-progress-indicator-root {
opacity: 0.4;
}

/* Start and End points - Horizon */

.ui5-progress-indicator-remaining-bar::before,
Expand Down
8 changes: 0 additions & 8 deletions packages/main/test/pages/ProgressIndicator.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,6 @@
<br />
<ui5-progress-indicator value-state="Information" value="25"></ui5-progress-indicator>
<br />
Disabled
<br />
<ui5-progress-indicator disabled value="25"></ui5-progress-indicator>
<br />
ValueState.None
<br />
<ui5-progress-indicator value-state="None" value="60"></ui5-progress-indicator>
Expand All @@ -85,10 +81,6 @@
<br />
<ui5-progress-indicator value-state="Information" value="60"></ui5-progress-indicator>
<br />
Disabled
<br />
<ui5-progress-indicator disabled value="60"></ui5-progress-indicator>
<br />
AccessibleName added
<ui5-progress-indicator id="PI" value="100" accessible-name="Hello world"></ui5-progress-indicator>
<br />
Expand Down
1 change: 0 additions & 1 deletion packages/playground/_stories/main/ProgressIndicator/ProgressIndicator.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export default {

const Template: UI5StoryArgs<ProgressIndicator, StoryArgsSlots> = (args) =>
html`<ui5-progress-indicator
?disabled="${ifDefined(args.disabled)}"
?hide-value="${ifDefined(args.hideValue)}"
value="${ifDefined(args.value)}"
display-value="${ifDefined(args.displayValue)}"
Expand Down
2 changes: 1 addition & 1 deletion packages/website/docs/_components_pages/main/ProgressIndicator.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ Use the <b>displayValue</b> property to define an alternative of the value, that
<DisplayValue />

### States
ProgressIndicator supports several semantic value states, disabled, etc.
ProgressIndicator supports several semantic value states.

<States />
1 change: 0 additions & 1 deletion packages/website/docs/_samples/main/ProgressIndicator/States/sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
<ui5-progress-indicator value="45" value-state="Information"></ui5-progress-indicator>
<ui5-progress-indicator value="15" value-state="Warning"></ui5-progress-indicator>
<ui5-progress-indicator value="65" value-state="Error"></ui5-progress-indicator>
<ui5-progress-indicator value="65" disabled></ui5-progress-indicator>

<!-- playground-fold -->
<script type="module" src="main.js"></script>
Expand Down