324 sidebar overflow #384
Closed
324 sidebar overflow #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cravend
reviewed
Apr 19, 2023
| <a | ||
| className="font-bold text-primary" | ||
| href={`/app/track/${track.id}`} | ||
| > | ||
| {track.name} | ||
| </a> | ||
| </td> | ||
| <td> | ||
| <td className="truncate max-w-[400px]"> |
There was a problem hiding this comment.
rather than arbitrarily truncating (which won't work for smaller screen sizes), set a max-w on the div wrappign the entire container.
Comment on lines
-43
to
-46
| const danceRecommendations = getDanceRecommendations( | ||
| audioFeatures.tempo, | ||
| audioFeatures.time_signature | ||
| ); |
There was a problem hiding this comment.
Why'd you delete dance recommendations?
|
See note in #324 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncated track, album, and artist names so that the sidebar is always visible.