-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
324 sidebar overflow #384
Closed
Closed
324 sidebar overflow #384
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1a87a3c
feat: removed horizontal scroll from TrackList
masondjoseph 62cad00
feat: truncated long album names in AlbumList
masondjoseph b87a839
feat: filled table to width of page in OffsetTrackList
masondjoseph 7100b0a
feat: truncated track and artist names in OffsetTrackList
masondjoseph f088911
Revert "feat: add dance recommendations to track page (#370)"
masondjoseph 7922d3e
feat: undid changes to main branch
masondjoseph de633a5
feat: filled table to width of page in TrackList
masondjoseph 9c06471
feat: truncated track names in TrackList
masondjoseph bb56d46
feat: truncated artist names in TrackList
masondjoseph 66443c0
feat: truncated album names in TrackList
masondjoseph eb3669b
feat: filled table to width of page in OffsetTrackList
masondjoseph dcc3933
feat: truncated track names in OffsetTrackList
masondjoseph 91d0de4
feat: truncated artist names in OffsetTrackList
masondjoseph 1c2b70c
feat: truncated album names in AlbumList
masondjoseph File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ const OffsetTrackList = ({ | |
showAlbum?: boolean; | ||
}) => ( | ||
<div className="overflow-x-auto"> | ||
<table className="table table-compact"> | ||
<table className="table table-compact w-full"> | ||
<thead> | ||
<tr> | ||
{showNumber && <th>#</th>} | ||
|
@@ -30,15 +30,15 @@ const OffsetTrackList = ({ | |
{tracks.map((track, index) => ( | ||
<tr className="hover" key={track.id}> | ||
{showNumber && <td>{index + 1}</td>} | ||
<td> | ||
<td className="truncate max-w-[400px]"> | ||
<a | ||
className="font-bold text-primary" | ||
href={`/app/track/${track.id}`} | ||
> | ||
{track.name} | ||
</a> | ||
</td> | ||
<td> | ||
<td className="truncate max-w-[400px]"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rather than arbitrarily truncating (which won't work for smaller screen sizes), set a max-w on the div wrappign the entire container. |
||
<ArtistLinks artists={track.artists} /> | ||
</td> | ||
{showAlbum && "album" in track && ( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why'd you delete dance recommendations?