-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non poissonian tests #189
Non poissonian tests #189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 55.73% 53.70% -2.03%
==========================================
Files 20 21 +1
Lines 3572 3707 +135
Branches 569 576 +7
==========================================
Hits 1991 1991
- Misses 1460 1595 +135
Partials 121 121
Continue to review full report at Codecov.
|
hi tono this looks really good. only comment so far is what do you think about changing the filename to |
* Changed np for numpy in the poisson_evaluations.py file * Added non-Poissonian comparative and consistency tests. * format docstrings * Rename non_poissonian_evaluations.py to binomial_evaluations.py * Update binomial_evaluations.py removed unused imports Co-authored-by: wsavran <[email protected]>
pyCSEP Pull Request Checklist
Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.
Fixes issue #(please fill in or delete if not needed).
Type of change:
Please delete options that are not relevant.
Checklist: