Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non poissonian tests #189

Merged

Conversation

bayonato89
Copy link
Contributor

@bayonato89 bayonato89 commented Jun 7, 2022

pyCSEP Pull Request Checklist

Please check out the contributing guidelines for some tips
on making pull requests to pyCSEP.

Fixes issue #(please fill in or delete if not needed).

Type of change:

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (this pull request adds no new code)
  • Unpublished science feature (This may require a science review)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #189 (fc28b70) into master (d13f74f) will decrease coverage by 2.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   55.73%   53.70%   -2.03%     
==========================================
  Files          20       21       +1     
  Lines        3572     3707     +135     
  Branches      569      576       +7     
==========================================
  Hits         1991     1991              
- Misses       1460     1595     +135     
  Partials      121      121              
Impacted Files Coverage Δ
csep/core/non_poissonian_evaluations.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13f74f...fc28b70. Read the comment docs.

@wsavran
Copy link
Collaborator

wsavran commented Jun 14, 2022

hi tono this looks really good. only comment so far is what do you think about changing the filename to binomial_tests.py?

@wsavran wsavran changed the base branch from master to v0.6.1-release-branch July 26, 2022 14:57
@wsavran wsavran merged commit affb7e8 into SCECcode:v0.6.1-release-branch Aug 18, 2022
wsavran added a commit to wsavran/pycsep that referenced this pull request Sep 22, 2022
* Changed np for numpy in the poisson_evaluations.py file
* Added non-Poissonian comparative and consistency tests.
* format  docstrings
* Rename non_poissonian_evaluations.py to binomial_evaluations.py
* Update binomial_evaluations.py
removed unused imports

Co-authored-by: wsavran <[email protected]>
wsavran added a commit that referenced this pull request Dec 12, 2022
* Quadtree csv reader (#186)
* New plotting routines (#190)
* Non poissonian tests (#189, #202, #205, #208, #209)
* Fix region border plot (#199)
* Added support for BSI catalog (#201)
* Fix consistency plots (#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants