Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pull request previews #196

Closed
jboix opened this issue Feb 6, 2024 · 1 comment · Fixed by #213
Closed

Enable pull request previews #196

jboix opened this issue Feb 6, 2024 · 1 comment · Fixed by #213
Assignees
@jboix
Labels
enhancement New feature or request released on @main

Comments

@jboix
Copy link
Contributor

jboix commented Feb 6, 2024

As a developer, I would like to be able to preview the github page of a pull request.

Acceptance Criteria:

  1. For each pull request a preview should be available for the standalone player page and the API documentation.
  2. The system should clean up after the preview is no longer needed.

See:
@jboix jboix added the enhancement New feature or request label Feb 6, 2024
@jboix jboix added this to Pillarbox Feb 6, 2024
@github-project-automation github-project-automation bot moved this to ✏️ Draft in Pillarbox Feb 6, 2024
@jboix jboix moved this from ✏️ Draft to 📋 Backlog in Pillarbox Feb 6, 2024
@jboix jboix self-assigned this Feb 20, 2024
@jboix jboix moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Feb 20, 2024
jboix added a commit to SRGSSR/pillarbox-web-demo that referenced this issue Feb 20, 2024
@jboix
chore(ci): add pull request previews
6c4cf04 
Addresses SRGSSR/pillarbox-web#196 by introducing pull request previews using
rossjrw/pr-preview-action. This new workflow enables us to review both visual and functional changes
before merging. Additional workflow updates include:

- The JamesIves/github-pages-deploy-action`+ has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
@jboix jboix mentioned this issue Feb 20, 2024
Merged
jboix added a commit to SRGSSR/pillarbox-web-demo that referenced this issue Feb 20, 2024
@jboix
chore(ci): add pull request previews
b35a81f 
Addresses SRGSSR/pillarbox-web#196 by introducing pull request previews using
rossjrw/pr-preview-action. This new workflow enables us to review both visual and functional changes
before merging. Additional workflow updates include:

- The JamesIves/github-pages-deploy-action`+ has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
jboix added a commit to SRGSSR/pillarbox-web-demo that referenced this issue Feb 20, 2024
@jboix
ci: add pull request previews
80634ab 
Addresses SRGSSR/pillarbox-web#196 by introducing pull request previews using
`rossjrw/pr-preview-action`. This new workflow enables us to review both visual and functional
changes before merging. Additional workflow updates include:

- The `JamesIves/github-pages-deploy-action` has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
jboix added a commit that referenced this issue Feb 20, 2024
@jboix
ci: add pull request previews
43d74da 
Resolves #196 by introducing pull request previews using `rossjrw/pr-preview-action`. This new
workflow enables us to review both visual and functional changes before merging. Additional workflow
changes include:

- The `JamesIves/github-pages-deploy-action` has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
@jboix jboix mentioned this issue Feb 20, 2024
Merged
@jboix jboix moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Feb 20, 2024
jboix added a commit that referenced this issue Feb 20, 2024
@jboix
ci: add pull request previews
3900f8e 
Resolves #196 by introducing pull request previews using `rossjrw/pr-preview-action`. This new
workflow enables us to review both visual and functional changes before merging.

The preview functionality work in the following manner:

1. **Triggering a Preview**: Whenever a pull request is either opened, re-opened, or updated, the
   project undergoes a build process. The contents of the `dist` directory are copied
   under `pr-preview/pr-${github.ref}` located in the `gh-pages` branch.

2. **Cleaning Up**: Once a pull request is closed, the corresponding preview folder (specific to the
   closed pull request) is deleted.

Additional workflowchanges include:

- The `JamesIves/github-pages-deploy-action` has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
jboix added a commit to SRGSSR/pillarbox-web-demo that referenced this issue Feb 20, 2024
@jboix
ci: add pull request previews
41edd85 
Addresses SRGSSR/pillarbox-web#196 by introducing pull request previews using
`rossjrw/pr-preview-action`. This new workflow enables us to review both visual and functional
changes before merging.

The preview functionality work in the following manner:

1. **Triggering a Preview**: Whenever a pull request is either opened, re-opened, or updated, the
   project undergoes a build process. The contents of the `dist` directory are copied
   under `pr-preview/pr-${github.ref}` located in the `gh-pages` branch.

2. **Cleaning Up**: Once a pull request is closed, the corresponding preview folder (specific to the
   closed pull request) is deleted.

Additional workflow updates include:

- The `JamesIves/github-pages-deploy-action` has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
jboix added a commit that referenced this issue Feb 20, 2024
@jboix
ci: add pull request previews
83a9432 
Resolves #196 by introducing pull request previews using `rossjrw/pr-preview-action`. This new
workflow enables us to review both visual and functional changes before merging.

The preview functionality work in the following manner:

1. **Triggering a Preview**: Whenever a pull request is either opened, re-opened, or updated, the
   project undergoes a build process. The contents of the `dist` directory are copied
   under `pr-preview/pr-${github.ref}` located in the `gh-pages` branch.

2. **Cleaning Up**: Once a pull request is closed, the corresponding preview folder (specific to the
   closed pull request) is deleted.

Additional workflowchanges include:

- The `JamesIves/github-pages-deploy-action` has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
jboix added a commit to SRGSSR/pillarbox-web-demo that referenced this issue Feb 20, 2024
@jboix
ci: add pull request previews
0b4f56f 
Addresses SRGSSR/pillarbox-web#196 by introducing pull request previews using
`rossjrw/pr-preview-action`. This new workflow enables us to review both visual and functional
changes before merging.

The preview functionality work in the following manner:

1. **Triggering a Preview**: Whenever a pull request is either opened, re-opened, or updated, the
   project undergoes a build process. The contents of the `dist` directory are copied
   under `pr-preview/pr-${github.ref}` located in the `gh-pages` branch.

2. **Cleaning Up**: Once a pull request is closed, the corresponding preview folder (specific to the
   closed pull request) is deleted.

Additional workflow updates include:

- The `JamesIves/github-pages-deploy-action` has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
github-merge-queue bot pushed a commit to SRGSSR/pillarbox-web-demo that referenced this issue Feb 20, 2024
@jboix
ci: add pull request previews
74829b0 
Addresses SRGSSR/pillarbox-web#196 by introducing pull request previews using
`rossjrw/pr-preview-action`. This new workflow enables us to review both visual and functional
changes before merging.

The preview functionality work in the following manner:

1. **Triggering a Preview**: Whenever a pull request is either opened, re-opened, or updated, the
   project undergoes a build process. The contents of the `dist` directory are copied
   under `pr-preview/pr-${github.ref}` located in the `gh-pages` branch.

2. **Cleaning Up**: Once a pull request is closed, the corresponding preview folder (specific to the
   closed pull request) is deleted.

Additional workflow updates include:

- The `JamesIves/github-pages-deploy-action` has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
jboix added a commit that referenced this issue Feb 20, 2024
@jboix
ci: add pull request previews
a50f20d 
Resolves #196 by introducing pull request previews using `rossjrw/pr-preview-action`. This new
workflow enables us to review both visual and functional changes before merging.

The preview functionality work in the following manner:

1. **Triggering a Preview**: Whenever a pull request is either opened, re-opened, or updated, the
   project undergoes a build process. The contents of the `dist` directory are copied
   under `pr-preview/pr-${github.ref}` located in the `gh-pages` branch.

2. **Cleaning Up**: Once a pull request is closed, the corresponding preview folder (specific to the
   closed pull request) is deleted.

Additional workflowchanges include:

- The `JamesIves/github-pages-deploy-action` has been updated from version 3 to version 4. This
  update introduces the following configurations to this action:
  - `force: false`: This disables force push to the deployment branch.
  - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is
    deployed.
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Feb 20, 2024
github-actions bot pushed a commit that referenced this issue Feb 23, 2024
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
1ee1686 
## [1.1.0](v1.0.1...v1.1.0) (2024-02-23)

### Refactor 🔩

* **srgssr-middleware:** move srgssr specific options declaration ([1138f89](1138f89))
* **srgssrg-middleware:** extraction of duplicated code in text tracks ([4ff0bc8](4ff0bc8))

### New Features 🚀

* **mediaComposition:** exposes the media URN through the main resources ([4b4c5a5](4b4c5a5))
* **srgssr-middleware:** add blocked segments support ([ad4e906](ad4e906)), closes [#211](#211)
* **srgssr-middleware:** add chapters support ([62ff02a](62ff02a)), closes [#204](#204)
* **srgssr-middleware:** add intervals support ([00ad42c](00ad42c)), closes [#212](#212)
* **srgssr-middleware:** add support for remote subtitles ([dbe9eb4](dbe9eb4)), closes [#203](#203)

### CI 🔁

* add pull request previews ([a50f20d](a50f20d)), closes [#196](#196)

### Docs 📖

* **analytics:** add tracking limitations section to known issues ([a69c916](a69c916)), closes [#208](#208)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jboix jboix

Labels
enhancement New feature or request released on @main
Projects
Pillarbox
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add pull request previews SRGSSR/pillarbox-web
1 participant
@jboix