-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle remote text tracks #203
Labels
Milestone
Comments
amtins
added a commit
that referenced
this issue
Feb 19, 2024
Resolves #203 by adding support for remote subtitles. Some SRG SSR content, such as mp4, may come with subtitles delivered as separate files, so these need to be explicitly added to the player. This also allows the developer to access remote subtitles via the `mediaData` object accessible from the `currentSource` player. ```javascript // Access the media subtitles player.currentSource().mediaData.subtitles ``` - add `subtitles` property to `mediaComposition.getMainResources` - add a function to add remote subtitles to the player from the srgssr middleware - add remote `subtitles` when resolving the resource in the setSource function - add test cases - replace the default media in the test page with an example containing multiple remote subtitles
amtins
added a commit
that referenced
this issue
Feb 19, 2024
Resolves #203 by adding support for remote subtitles. Some SRG SSR content, such as mp4, may come with subtitles delivered as separate files, so these need to be explicitly added to the player. This also allows the developer to access remote subtitles via the `mediaData` object accessible from the `currentSource` player. ```javascript // Access the media subtitles player.currentSource().mediaData.subtitles ``` - add `subtitles` property to `mediaComposition.getMainResources` - add a function to add remote subtitles to the player from the srgssr middleware - add remote `subtitles` when resolving the resource in the setSource function - add test cases - replace the default media in the test page with an example containing multiple remote subtitles
amtins
added a commit
that referenced
this issue
Feb 23, 2024
Resolves #203 by adding support for remote subtitles. Some SRG SSR content, such as mp4, may come with subtitles delivered as separate files, so these need to be explicitly added to the player. This also allows the developer to access remote subtitles via the `mediaData` object accessible from the `currentSource` player. ```javascript // Access the media subtitles player.currentSource().mediaData.subtitles ``` - add `subtitles` property to `mediaComposition.getMainResources` - add a function to add remote subtitles to the player from the srgssr middleware - add remote `subtitles` when resolving the resource in the setSource function - add test cases - replace the default media in the test page with an example containing multiple remote subtitles
github-actions bot
pushed a commit
that referenced
this issue
Feb 23, 2024
## [1.1.0](v1.0.1...v1.1.0) (2024-02-23) ### Refactor 🔩 * **srgssr-middleware:** move srgssr specific options declaration ([1138f89](1138f89)) * **srgssrg-middleware:** extraction of duplicated code in text tracks ([4ff0bc8](4ff0bc8)) ### New Features 🚀 * **mediaComposition:** exposes the media URN through the main resources ([4b4c5a5](4b4c5a5)) * **srgssr-middleware:** add blocked segments support ([ad4e906](ad4e906)), closes [#211](#211) * **srgssr-middleware:** add chapters support ([62ff02a](62ff02a)), closes [#204](#204) * **srgssr-middleware:** add intervals support ([00ad42c](00ad42c)), closes [#212](#212) * **srgssr-middleware:** add support for remote subtitles ([dbe9eb4](dbe9eb4)), closes [#203](#203) ### CI 🔁 * add pull request previews ([a50f20d](a50f20d)), closes [#196](#196) ### Docs 📖 * **analytics:** add tracking limitations section to known issues ([a69c916](a69c916)), closes [#208](#208)
🎉 This issue has been resolved in version 1.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a developer, I want the player to support external subtitles from
mediaComposition
.Acceptance Criteria
The text was updated successfully, but these errors were encountered: