chore(demo): player captions settings focus #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success146 tests passing in 9 suites. Report generated by 🧪jest coverage report action from 494bf47 |
When navigating with the keyboard, the focus is not correctly set on the `select` html elements of the captions settings. This is caused by two css rules in two different files: 1. **player.scss**, `select` set to `all:unset` 2. **index.scss**, `select` set to `outline:none` Set `outline` to `solid` during `focus-within`. This solution was preferred while waiting for the end of the transition to Lit.
amtins
force-pushed
the
chore/captions-settings-focus
branch
from
7970bc2 to
494bf47
Compare
jboix
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When navigating with the keyboard, the focus is not correctly set on the
selecthtml elements of the captions settings.This is caused by two css rules in two different files:
selectset toall:unsetselectset tooutline:noneChanges made
outlinetosolidduringfocus-within. This solution was preferred while waiting for the end of the transition to Lit.