Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing hyperfine.exe #2773

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

jcwillox
Copy link
Contributor

In the latest release of hyperfine, the binary was moved into a subdirectory hyperfine-v$version-x86_64-pc-windows-msvc, this PR adds extract_dir to fix that.

@rashil2000
Copy link
Member

Tested locally, works.

Couple of nits:

  • hyperfine's CD was recently updated to include 32-bit binaries as well, it'd be great if you could include them (see fd's manifest for reference)
  • Kindly follow the standard commit message format: [email protected]: Specify extract_dir entry or [email protected]: Include 32bit binary

@jcwillox
Copy link
Contributor Author

Hmm, I'd argue that should be a separate PR but I guess they're kinda related, I'll add it anyways as it might make it easier for the maintainers. As for the commit messages, it doesn't really matter when they squash merge it there will be a single commit which they can name however they see fit.

Copy link
Contributor

@dwettstein dwettstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwettstein dwettstein merged commit 4f9c6aa into ScoopInstaller:master Oct 19, 2021
@jcwillox jcwillox deleted the patch-1 branch October 19, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants