-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let windows users have the full color experience #427
Comments
I agree, let's change this. Related (old) discussion: #37 |
@jcwillox Could you let me know if this works in https://github.com/sharkdp/hyperfine/releases/tag/v1.12.0 ? |
Yessss, fantastic colours are working correctly, thanks! Side note the latest update broke the scoop manifest, as the binary is now inside a directory, I've already published a PR to fix this though ScoopInstaller/Main#2773. |
Thank you! |
I don't believe anyone's asked this before but I can't see a good reason to downgrade windows users from
full
tocolor
especially when they explicitly specify it.hyperfine/src/main.rs
Lines 219 to 222 in 1027940
In fact, you may consider making windows default to
full
as Windows Terminal has support for true colour and recently added bold support in the previews. As well the default windows conhost now has support for ANSI colours, although you will need to enable support in your program or enable it globally via the registry. That last bit isn't as important as I'd assume most people wouldn't be using hyperfine with conhost.https://stackoverflow.com/a/51681675/12346307 enabling ANSI support for conhost
https://github.com/mattn/go-colorable a library I've used before that handles enabling ANSI support, not sure if rust has an equivalent.
The text was updated successfully, but these errors were encountered: