Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve run_all funtion from Experiment.py #62

Closed
1 task done
SebChw opened this issue Sep 4, 2023 · 2 comments
Closed
1 task done

Improve run_all funtion from Experiment.py #62

SebChw opened this issue Sep 4, 2023 · 2 comments
Assignees

Comments

@SebChw
Copy link
Owner

SebChw commented Sep 4, 2023

2 Things were suggested:

  1. Other way of skipping steps - this integer indicator may be very cumbersome in later stages.
    2. Checking whether the code was changed.

Both things should be simple. My suggestion for now is:

  1. We iterate over all checks and if all are passed we consider step to be passed.
    2. As step is being run we save model's code to some hidden folder and calculate it's hash. When step is run the next time. We compare hashes. We show warning to the user that this step should be rerun.

If anyone solving this task will have better ideas please suggest them

Acceptance Criteria:

  • Checking progress within experiment is no longer done based on integer counter
    Some primitive method for checking whether code changed and experiment should be done is implemented
@SebChw SebChw self-assigned this Sep 8, 2023
@SebChw
Copy link
Owner Author

SebChw commented Sep 8, 2023

I think the second checkmark should be another issue.

kordc added a commit that referenced this issue Sep 26, 2023
Fixing some issues closes #64, closes #62
@kordc
Copy link
Collaborator

kordc commented Sep 29, 2023

So we can close this one? @SebChw

@kordc kordc closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants