Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] add some type hints to selenium.webdriver.support #13070

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

pinterior
Copy link
Contributor

Description

Add type hints to py/selenium/webdriver/support/{expected_condition, wait}.py

Related to #9480

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2023

CLA assistant check
All committers have signed the CLA.

@titusfortner titusfortner requested review from isaulv and symonk October 30, 2023 15:17
@codecov-commenter
Copy link

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (ee55ea2) 56.49% compared to head (954a1a7) 57.62%.
Report is 3 commits behind head on trunk.

❗ Current head 954a1a7 differs from pull request most recent head a76a8c0. Consider uploading reports for the commit a76a8c0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13070      +/-   ##
==========================================
+ Coverage   56.49%   57.62%   +1.12%     
==========================================
  Files          86       86              
  Lines        5255     5258       +3     
  Branches      187      203      +16     
==========================================
+ Hits         2969     3030      +61     
+ Misses       2099     2025      -74     
- Partials      187      203      +16     
Files Coverage Δ
py/selenium/webdriver/support/wait.py 76.36% <66.66%> (+5.77%) ⬆️
.../selenium/webdriver/support/expected_conditions.py 71.49% <57.81%> (+26.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AutomatedTester AutomatedTester merged commit 61ea36e into SeleniumHQ:trunk Oct 31, 2023
@pinterior pinterior deleted the py-typing-support branch October 31, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants