Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py: fix WebDriverWait type hints for WebElement #13108

Merged

Conversation

pinterior
Copy link
Contributor

Description

Closes #13087 (introduced by #13070 )

  • make WebDriverWait to accept WebElement as driver parameter
  • type safe method invocation in WebDriverWait#until and WebDriverWait#until_not

Motivation and Context

more precise type checking

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (0c86525) 57.70% compared to head (219c259) 57.47%.

❗ Current head 219c259 differs from pull request most recent head 6827d72. Consider uploading reports for the commit 6827d72 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13108      +/-   ##
==========================================
- Coverage   57.70%   57.47%   -0.24%     
==========================================
  Files          86       86              
  Lines        5289     5293       +4     
  Branches      208      221      +13     
==========================================
- Hits         3052     3042      -10     
- Misses       2029     2030       +1     
- Partials      208      221      +13     
Files Coverage Δ
py/selenium/webdriver/support/wait.py 55.17% <66.66%> (-21.20%) ⬇️
.../selenium/webdriver/support/expected_conditions.py 71.15% <50.00%> (-0.35%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isaulv isaulv added the C-py label Nov 9, 2023
@isaulv
Copy link
Contributor

isaulv commented Nov 9, 2023

LGTM.

@diemol diemol merged commit 10adfe8 into SeleniumHQ:trunk Nov 9, 2023
@pinterior pinterior deleted the fix-webdriverwait-hint-for-webelement branch November 10, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: incorrect type hint to WebDriverWait init
4 participants