Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup: hover behaviour unreliable #3239

Closed
james-ff opened this issue Oct 24, 2018 · 5 comments · Fixed by #3257
Closed

Popup: hover behaviour unreliable #3239

james-ff opened this issue Oct 24, 2018 · 5 comments · Fixed by #3257
Labels

Comments

@james-ff
Copy link

Bug Report

Steps

In the Semantic UI & Semantic UI React examples, go to Popup and try the Flowing Example

  • You should find that on SUI the Popup on hover closes only when your mouse leaves the bounds of the popup content, but on SUIR the popup content closes unpredictably, even when your mouse is within the popup content bounds.
  • I am finding cases in my website where buttons and other interactable components are not able to be interacted with reliably when wrapped in a Popup.

SUI: https://semantic-ui.com/modules/popup.html
SUIR: https://react.semantic-ui.com/modules/popup/

Expected Result

The Popup hover behaviour on SUIR should match SUI.

Actual Result

The SUIR Popup on hover mode unreliably closes, even when the mouse is within the bounds of the popup content.

Version

0.83.0

@layershifter
Copy link
Member

You should find that on SUI the Popup on hover closes only when your mouse leaves the bounds of the popup content, but on SUIR the popup content closes unpredictably, even when your mouse is within the popup content bounds.

I tested in Chrome and don't any difference, however SUI has transitions. Can you record a gif? Becuase your issue is not obvious to me.

I am finding cases in my website where buttons and other interactable components are not able to be interacted with reliably when wrapped in a Popup.

It may be similar to #3231 (comment)

@james-ff
Copy link
Author

james-ff commented Oct 24, 2018

I'm using the latest non-beta version of Firefox:

  • I am not clicking in either of these recordings, just moving the cursor around
  • To clarify, in SUIR the popup closes unpredictably, but seems to be based on cursor movement
  • Do you think that the transition is causing the disparity?

SUI:
SUI

SUI React:
SUIR

@layershifter
Copy link
Member

Now it's more clear, thanks.

@layershifter layershifter changed the title Popup hover behaviour unreliable. Popup: hover behaviour unreliable Oct 24, 2018
@vanya2h
Copy link

vanya2h commented Oct 29, 2018

+1. Have same issue!

@Fabianopb
Copy link
Member

Fabianopb commented Nov 4, 2018

Hello! I've been a heavy user of SUIR for some time and I've been planning to start contributing to this repo.

I've investigated this issue and possibly found a solution, could submit a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants