-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Portal): hover behavior fixed in Portal's event handlers #3257
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #3257 +/- ##
==========================================
+ Coverage 99.92% 99.92% +<.01%
==========================================
Files 169 169
Lines 2802 2803 +1
==========================================
+ Hits 2800 2801 +1
Misses 2 2
Continue to review full report at Codecov.
|
@Fabianopb thank you for the investigation, fix looks correctly to me. I will test it on weekend. |
Fantastic, thanks! I've updated the branch to the latest and approved it for merge. We can merge once tests pass. |
@levithomason Codecov will never pass if you made "Update branch" on Github: |
Hi there, Is there any idea to resolve please? should I update the Semantic ui react version? Thanks! |
@wangjitai the team has been cutting releases very often and last one was 19 days ago, I'd say it shouldn't take too long for the next one. |
Exactly what i was looking for - Hopefully the new version releases soon! |
Any idea when this will go to npm? |
Hey, Any idea when this will be released as part as 0.84? |
Originally
Portal
closes onmouseleave
. However,mouseleave
is fired when "the pointer has exited the element and all of its descendants" (ref: https://developer.mozilla.org/en-US/docs/Web/Events/mouseleave).For that reason the
Popup
was closing when the pointer exited the inner elements, but not necessarily thePortal
itself (which is used to render thePopup
).Gif of the fixed behavior:
The solution was to cancel the
handlePortalMouseLeave
event in case the event's target doesn't match the portal node. A test was also added. It seemed a clean enough solution for this bug, let me know what you think!Cheers!
(fixes #3239)