Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats page of Settings menu #1162

Merged
merged 26 commits into from
Mar 18, 2021
Merged

Stats page of Settings menu #1162

merged 26 commits into from
Mar 18, 2021

Conversation

enikonemeth
Copy link
Contributor

No description provided.

@enikonemeth enikonemeth added this to the Sprint 228 milestone Jan 28, 2021
@enikonemeth enikonemeth self-assigned this Jan 28, 2021
@sensenet
Copy link

sensenet bot commented Jan 28, 2021 •
edited
Loading

Site name Url Last deploy
sn-app-dev https://6053305467994ad4818ccb6a--sn-app-dev.netlify.app Thu Mar 18 2021 - 10:49:57 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://605330682fb4e4cc1aa48159--sn-react-component-docs-dev.netlify.app Thu Mar 18 2021 - 10:50:17 GMT+0000 (Coordinated Universal Time)

@sensenet
Copy link

sensenet bot commented Jan 28, 2021

Site name Url Last deploy
sn-app-dev https://6012e0e8b5198c1f503353b0--sn-app-dev.netlify.app Thu Jan 28 2021 - 16:06:05 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://6012e0eb6ddb7128bd59ad12--sn-react-component-docs-dev.netlify.app Thu Jan 28 2021 - 16:06:04 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Jan 28, 2021 •
edited
Loading

Codecov Report

Merging #1162 (7586ec8) into develop (243e4bc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1162   +/-   ##
========================================
  Coverage    93.77%   93.77%           
========================================
  Files          232      232           
  Lines         6585     6585           
  Branches      1685     1685           
========================================
  Hits          6175     6175           
  Misses         410      410
Impacted Files Coverage Δ
...kages/sn-hooks-react/src/hooks/use-version-info.ts 97.36% <ø> (ø)
.../sn-controls-react/src/fieldcontrols/file-size.tsx 97.29% <100.00%> (-0.53%) ⬇️
packages/sn-controls-react/src/helpers.ts 90.47% <100.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243e4bc...7586ec8. Read the comment docs.

@herflis herflis modified the milestones: Sprint 228, Sprint 229 Feb 3, 2021
@herflis herflis removed this from the Sprint 229 milestone Feb 17, 2021
Base automatically changed from feature/settings to develop March 10, 2021 08:15
@enikonemeth enikonemeth marked this pull request as ready for review March 10, 2021 10:14
@enikonemeth enikonemeth changed the title Stats page of Settings menu -WIP Stats page of Settings menu Mar 10, 2021
@enikonemeth enikonemeth requested review from taki9 and herflis March 10, 2021 10:14
taki9
taki9 reviewed Mar 12, 2021
View reviewed changes
Copy link
Contributor

@taki9 taki9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think block titles (Storage, Components, Installed packages) should be more emphasized some way.

apps/sensenet/src/components/settings/multi-part-progress-line.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/multi-part-progress-line.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/multi-part-progress-line.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/multi-part-progress-line.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/stats-components-widget.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/stats-components-widget.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/stats-installed-packages-widget.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/stats-storage-widget.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/stats-storage-widget.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/stats.tsx Outdated Show resolved Hide resolved
@enikonemeth
Copy link
Contributor Author

I think block titles (Storage, Components, Installed packages) should be more emphasized some way.

Can you please give me details?
https://miro.com/app/board/o9J_klNk0R4=/
On the design it has the same font size and type like other texts.

@enikonemeth enikonemeth requested a review from taki9 March 12, 2021 19:59
@enikonemeth enikonemeth requested a review from taki9 March 18, 2021 10:43
@enikonemeth enikonemeth merged commit 5fc068e into develop Mar 18, 2021
@enikonemeth enikonemeth deleted the feature/settings_stats branch March 18, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herflis herflis herflis approved these changes

@taki9 taki9 taki9 approved these changes

Assignees

@enikonemeth enikonemeth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enikonemeth @herflis @taki9