Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppBar has no padding to the status bar on some devices (add homework or infosheet) #10

Closed
nilsreichardt opened this issue Jun 27, 2021 · 0 comments · Fixed by #833
Closed

AppBar has no padding to the status bar on some devices (add homework or infosheet) #10

nilsreichardt opened this issue Jun 27, 2021 · 0 comments · Fixed by #833
Labels
bug Something isn't working. feature: homework feature: information sheet Information sheets are posted to courses as a way to announce information. ui / ux w: add-information-sheet-page

Comments

@nilsreichardt
Copy link
Member

nilsreichardt commented Jun 27, 2021 •
edited
Loading

Description

The add homework and infosheet page is effected from this ui bug.

Screenshot_20210627-173529.png

Tested device

Google Pixel 4a
@Jonas-Sander Jonas-Sander added page: homework-creation feature: homework feature: information sheet Information sheets are posted to courses as a way to announce information. ui / ux bug Something isn't working. labels Jan 31, 2022
@nilsreichardt nilsreichardt mentioned this issue Aug 26, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 31, 2023
@nilsreichardt
Change save button for adding homework and information sheets (#833)
dac37b9 
I replaced the save button with an elevated button. Inspired by Google
Calendar.

| Name | Before | After |
|--------|--------|-|
| Pixel 4a (Dark Mode)
| ![telegram-cloud-photo-size-2-5429174619237108975-y](https://github.com/SharezoneApp/sharezone-app/assets/24459435/209a1197-c8bb-4915-9c5b-2dac2877d9e1)
| ![telegram-cloud-photo-size-2-5429174619237108979-y](https://github.com/SharezoneApp/sharezone-app/assets/24459435/d7424e7f-e941-402a-a60e-a6b07a9272a3)
|
| Pixel 4a (Light Mode)
| ![telegram-cloud-photo-size-2-5429174619237108976-y](https://github.com/SharezoneApp/sharezone-app/assets/24459435/2222c59e-eb97-4496-8a57-2ce0897c3e23)
| ![telegram-cloud-photo-size-2-5429174619237108977-y](https://github.com/SharezoneApp/sharezone-app/assets/24459435/6f70a844-df39-4250-951b-4d08add2b265)
|
| iPhone 14 (Dark Mode) | ![Simulator Screenshot - iPhone 14 -
2023-08-26 at 20 06
52](https://github.com/SharezoneApp/sharezone-app/assets/24459435/c3c3119b-0ef2-42b5-ab71-e637483444ff)
| ![Simulator Screenshot - iPhone 14 - 2023-08-26 at 20 06
11](https://github.com/SharezoneApp/sharezone-app/assets/24459435/56f7cbb1-9f60-4fe2-b632-f937c996a719)
|
| iPhone 14 (Light Mode) | ![Simulator Screenshot - iPhone 14 -
2023-08-26 at 20 07
24](https://github.com/SharezoneApp/sharezone-app/assets/24459435/5ffa0831-b21b-4838-8a09-f9f446286810)
| ![Simulator Screenshot - iPhone 14 - 2023-08-26 at 20 05
59](https://github.com/SharezoneApp/sharezone-app/assets/24459435/70f28a27-fc79-4bd6-892e-fd4f00f721cc)
|

Fixes #10
github-merge-queue bot pushed a commit that referenced this issue Sep 8, 2023
@nilsreichardt
Fix error when loading folders (#920)
c3ce579 
This PR fixes the following error:

```
_TypeError (type 'Null' is not a subtype of type 'String')
[log] #0      new Folder.fromData
folder.dart:69
#1      new FileSharingData.fromData.<anonymous closure>
filesharing_data.dart:49
#2      decodeMap.<anonymous closure>
helper_functions.dart:23
#3      MapBase.map (dart:collection/maps.dart:82:28)
#4      decodeMap
helper_functions.dart:23
#5      new FileSharingData.fromData
filesharing_data.dart:48
#6      FileSharingGateway.courseFoldersStream.<anonymous closure>.<anonymous closure>
file_sharing_api.dart:49
#7      MappedListIterable.elementAt (dart:_internal/iterable.dart:415:31)
#8      ListIterator.moveNext (dart:_internal/iterable.dart:344:26)
#9      new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189:27)
#10     new _GrowableList.of (dart:core-patch/growable_array.dart:150:28)
#11     new List.of (dart:core-patch/array_patch.dart:47:28)
#12     ListIterable.toList (dart:_internal/iterable.dart:214:7)
#13     FileSharingGateway.courseFoldersStream.<anonymous closure>
```
@nilsreichardt nilsreichardt moved this to Closed in Triage May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. feature: homework feature: information sheet Information sheets are posted to courses as a way to announce information. ui / ux w: add-information-sheet-page
Projects
Triage
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change save button for adding homework and information sheets SharezoneApp/sharezone-app
3 participants
@nilsreichardt @Jonas-Sander @Sharezone-Admin