-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*): add GitHub bug report template #12
Conversation
Wäre noch gut zu wissen was die Version ist (mit Anleitung wo man das sieht). Ich fand eigentlich unsere GitLab-Template ganz gut, da war auch nochmal ne Aufteilung explizit nach was passiert und was passieren sollte (das beides beschrieben wird). Hast du die aus GitLab extra nicht genommen bzw. was ist deine Meinung dazu? |
I just used another one, because this was already translated into English and I was to lazy to translate the GitLab template from German to English 👀🙈 I added in 82559c5f55de6291e625d9482a20024bbaf2b0ee a few things from the GitLab template into the GitHub template. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some more comments - after fixing these you can merge the template 👍
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
- OS: | ||
<!-- (In which version of the app does the error occur? You can find the version under Settings > "About us". Otherwise you can find a tutorial with picture under this link: https://sharezone.zendesk.com/hc/de/articles/360013355879-Welche-Version-der-App-habe-ich-installiert-) --> | ||
- App version: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sollte der Text nicht unter den "- App Version" Stichpunkt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich hatte den Kommentar jetzt immer über den Punkt geschrieben (selbes für OS
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Da hatte ich das gar nicht gecheckt, weil device/OS so related waren. Ich würde sagen schreib's drunter, das hat mich gerade wieder verwirrt 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also dann immer den Kommentar unter das Feld schreiben? Wie z.B.
## Tested device
- Device:
<!-- On which device did the bug occur? iPhone 12? Google Pixel 5? Honor View 10? -->
- OS:
<!-- Which OS do you use? Android 11? iOS 14? macOS 15? -->
- App version:
<!-- (In which version of the app does the error occur? You can find the version under Settings > "About us". Otherwise you can find a tutorial with picture under this link: https://sharezone.zendesk.com/hc/de/articles/360013355879-Welche-Version-der-App-habe-ich-installiert-) -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Habs aktualisiert 👍
@Jonas-Sander We can also use the new issue form feature: https://youtu.be/qQE1BUkf2-s |
Looks good, I'm down 👍 |
R.I.P |
This PR fixes the following error: ``` _TypeError (type 'Null' is not a subtype of type 'String') [log] #0 new Folder.fromData folder.dart:69 #1 new FileSharingData.fromData.<anonymous closure> filesharing_data.dart:49 #2 decodeMap.<anonymous closure> helper_functions.dart:23 #3 MapBase.map (dart:collection/maps.dart:82:28) #4 decodeMap helper_functions.dart:23 #5 new FileSharingData.fromData filesharing_data.dart:48 #6 FileSharingGateway.courseFoldersStream.<anonymous closure>.<anonymous closure> file_sharing_api.dart:49 #7 MappedListIterable.elementAt (dart:_internal/iterable.dart:415:31) #8 ListIterator.moveNext (dart:_internal/iterable.dart:344:26) #9 new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189:27) #10 new _GrowableList.of (dart:core-patch/growable_array.dart:150:28) #11 new List.of (dart:core-patch/array_patch.dart:47:28) #12 ListIterable.toList (dart:_internal/iterable.dart:214:7) #13 FileSharingGateway.courseFoldersStream.<anonymous closure> ```
No description provided.