Markdown analytics are wrong when editing a homework. #1115
Labels
bug
Something isn't working.
feature: analytics
Includes everything that is related to analytics and usage tracking
feature: homework
w: add-homework-page
Creation Dialog of a homework. Get to it by pressing the add homework button on the homework page.
Comments
Jonas-Sander
added
bug
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 9, 2023
Continuation of #1113. * Added a test for editing a homework * Move analytics from the UI into the bloc. * Remove `oldHomework` from `bloc.submit` because it's unnecessary. * Change bloc method: `bool isValid()` to `void validateInputOrThrow()`. I'm trying to not change logic in the refactorings, so that structural and behavioral changes are seperated. This is why I'm leaving this broken behavior in for now #1115.
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 25, 2023
Replaced `HomeworkDialogBloc` with a `Bloc` from [package:bloc](https://pub.dev/packages/bloc). Added unit and golden tests. I tried to keep the behavior mostly the same. There are still some of the same bugs as before (e.g. #1117), they should be fixed in separate PRs. Differences to old behavior: * If any field is changed the quit prompt will appear (e.g. submission enabled, submission time and is private were ignored before) * Pressing save will show errors (red text) like before, but not a `SnackBar` Not so great: * `PrefilledTextField` will we rebuild each time the text changes (title, description) - didn't see any problems because of this though * Code quality is mediocre (e.g. using `HomeworkDto` for the current state in the bloc which lead to _horrible_ hacks for the todo `DateTime`) * Quality of tests if mediocre, good amount of duplication. Also instead of testing each thing seperately I threw some different scenarios (private, not private, with submissions) together which just tested different things at the same time. * Markdown analytics not tested automatically, just manually once * No automatic tests for awaiting or not awaiting API calls depending on if attachments are added because of the Firestore offline behavior where Future won't complete (it works though, tested it manually several times) Good: * Good amount of test coverage * Several golden tests (happy path and errors) * UI is decoupled from business logic * Should be a bit better to add functionality and maintain than before * 🗿 https://github.com/SharezoneApp/sharezone-app/assets/29028262/86ef445f-2424-4607-b3fc-d403d70eafa2 https://github.com/SharezoneApp/sharezone-app/assets/29028262/64332530-0181-4bbf-8a35-d31e62405bc8 Fixes #1115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When editing a homework and not using markdown in the new description a "
markdown_used" analytics event is logged regardless.Steps to reproduce the bug
Current broken behavior
A
markdown_used-event is logged.Expected behavior
No
markdown_used-event should be logged.Screenshots, videos or logs
Tested device
Additional context
Possible solution
The text was updated successfully, but these errors were encountered: