Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue refactoring homework dialog. #1113

Merged
merged 17 commits into from
Oct 5, 2023
Merged

Continue refactoring homework dialog. #1113

merged 17 commits into from
Oct 5, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Oct 5, 2023 •
edited
Loading

Continue refactoring the homework dialog (see #1112)

  • Add loadCloudFiles to HomeworkDialogApi
  • Make attributes of HomeworkDialogApi private
  • Add empty state and edit state widget tests (can probably be replaced by golden tests in the future)
  • Add widget test that inputs data and compares it to the UserInput

@Jonas-Sander Jonas-Sander added feature: homework w: add-homework-page Creation Dialog of a homework. Get to it by pressing the add homework button on the homework page. refactoring Restructuring and cleaning up existing code without changing its existing behaviour. labels Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit e6493a3):

https://sharezone-test--pr1113-homework-dialog-cont-43q2qgtx.web.app

(expires Sun, 08 Oct 2023 17:04:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander marked this pull request as ready for review October 5, 2023 17:00
nilsreichardt
nilsreichardt approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 0784b5d Oct 5, 2023
@Jonas-Sander Jonas-Sander deleted the homework-dialog-continued branch October 5, 2023 18:39
@Jonas-Sander Jonas-Sander mentioned this pull request Oct 6, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2023
@Jonas-Sander
Continue refactoring homework dialog. (#1116)
3ca0634 
Continuation of #1113.

* Added a test for editing a homework
* Move analytics from the UI into the bloc.
* Remove `oldHomework` from `bloc.submit` because it's unnecessary.
* Change bloc method: `bool isValid()` to `void validateInputOrThrow()`.

I'm trying to not change logic in the refactorings, so that structural
and behavioral changes are seperated. This is why I'm leaving this
broken behavior in for now #1115.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
feature: homework refactoring Restructuring and cleaning up existing code without changing its existing behaviour. testing w: add-homework-page Creation Dialog of a homework. Get to it by pressing the add homework button on the homework page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-Sander @nilsreichardt