Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events page always colors dates in red. #128

Closed
Jonas-Sander opened this issue Feb 15, 2022 · 1 comment · Fixed by #1682
Closed

Events page always colors dates in red. #128

Jonas-Sander opened this issue Feb 15, 2022 · 1 comment · Fixed by #1682
Labels
bug Something isn't working. good first issue This issue is good for new contributors. Easy to fix. ui / ux w: events-overview-page Events ("Termine") page that shows all (future) events of the user.

Comments

@Jonas-Sander
Copy link
Collaborator

Describe the bug

When viewing events on the event page then those events will always have a red ("urgent") color regardless when the date is.

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Go to events page
  2. Add an event for two days in the future
  3. Add an event for two months in the future

Current broken behavior

The color of the date of both events will be colored red.

Expected behavior

Only the dates of events in the near future (e.g. 7 days? idk) / urgent events should be colored red.
(There expected behavior should be discussed further e.g. maybe the dates of exams should be colored red sooner than normal events as you might need more preparation for exams)

Screenshots, videos or logs

image

Tested device

  • Device: MacBook Pro 2018
  • OS: Big Sur 11.6
  • App type: web app
  • App version: 1.6.2 (316)

Additional context

Reported by discord user here: https://discord.com/channels/545668860859252746/623985162488905759/943167486365433946
@Jonas-Sander
Copy link
Collaborator Author

Color is currently hardcoded here: https://github.com/SharezoneApp/sharezone-app/blob/main/app/lib/timetable/src/widgets/events/calender_event_card.dart#L54

@Jonas-Sander Jonas-Sander added the w: events-overview-page Events ("Termine") page that shows all (future) events of the user. label Mar 16, 2022
@nilsreichardt nilsreichardt added the good first issue This issue is good for new contributors. Easy to fix. label Feb 13, 2024
@ImGxrke ImGxrke mentioned this issue Jul 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 16, 2024
@ImGxrke @nilsreichardt
Only highlight soon upcoming events (#1682)
b34ff46 
Fixes #128


![image](https://github.com/SharezoneApp/sharezone-app/assets/29801805/cd320d56-34be-4223-a848-2861545e2368)

---------

Co-authored-by: nilsreichardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. good first issue This issue is good for new contributors. Easy to fix. ui / ux w: events-overview-page Events ("Termine") page that shows all (future) events of the user.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only highlight soon upcoming events
3 participants
@nilsreichardt @Jonas-Sander @Sharezone-Admin