Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only highlight soon upcoming events #1682

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Only highlight soon upcoming events #1682

merged 3 commits into from
Jul 16, 2024

Conversation

ImGxrke
Copy link
Contributor

@ImGxrke ImGxrke commented Jul 1, 2024

Fixes #128

image

@github-actions github-actions bot added feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). ui / ux testing labels Jul 1, 2024
@nilsreichardt nilsreichardt added the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jul 1, 2024
@github-actions github-actions bot removed the safe to test Used for fork PRs when the code is safe to test to trigger our CI. label Jul 1, 2024
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I also updated the screenshots for the goldens (using sz test -ug) 👍

Copy link

github-actions bot commented Jul 1, 2024

Visit the preview URL for this PR (updated for commit de250ab):

https://sharezone-test--pr1682-dynamic-event-page-d-t95qfqvw.web.app

(expires Thu, 04 Jul 2024 17:54:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Jul 16, 2024
Merged via the queue into SharezoneApp:main with commit b34ff46 Jul 16, 2024
40 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing ui / ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events page always colors dates in red.
3 participants