Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachements of private homeworks are automatically uploaded into the public attachements file-sharing folder of the course. #132

Closed
Jonas-Sander opened this issue Mar 9, 2022 · 0 comments · Fixed by #1150
Closed

Attachements of private homeworks are automatically uploaded into the public attachements file-sharing folder of the course. #132

Jonas-Sander opened this issue Mar 9, 2022 · 0 comments · Fixed by #1150
Assignees
@Jonas-Sander
Labels
bug Something isn't working. feature: attachments Attachments are files that can be added to homeworks or information sheets. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course.

Comments

@Jonas-Sander
Copy link
Collaborator

Describe the bug

When uploading a homework with an attachment, the attachment will be automatically uploaded into the "attachments" folder of the course where it can be seen by everyone in the course.

Steps to reproduce the bug

  1. [User A] Create a new course called e.g. "Mathe".
  2. [User A] Copy the sharecode.
  3. [User B] Join the course via the copied sharecode.
  4. [User A] Create a new homework titled "private" with an attachment which is set to private.
  5. [User B] Go into file-sharing > "Mathe" > "attachements" ("Anhänge")

Current broken behavior

The attachment of the private homework will be visible for everyone in the course by visiting the attachments folder of the course. In the example above [User B] can see the private attachment.

Expected behavior

The attachment should not be visible to other users.

Screenshots, videos or logs

Note:

  1. The video was recorded in a version of the app where there was still a bug that let the SnackBar stay visible forever when uploading a homework. This bug is already fixed in main.
  2. Instead of switching accounts we just use the same account and observer that the file was uploaded in the attachments folder because currently if one sees a file in the file-sharing page then everyone sees it. This might be changed in the future.
FILE.2022-03-09.13.07.12.mp4

Tested device

  • Device: Pixel 4a
  • OS: Android 12
  • App type: Android app
  • App version: 1.6.1 (315)

Additional context

Original issue: https://gitlab.com/codingbrain/sharezone/sharezone-app/-/issues/141

Possible solution

We might:

  • Not upload the attachment into the attachment folder at all.
  • Make the attachment only visible inside the attachment folder for the person who uploaded it.
@Jonas-Sander Jonas-Sander added bug Something isn't working. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: attachments Attachments are files that can be added to homeworks or information sheets. labels Mar 9, 2022
@Jonas-Sander Jonas-Sander self-assigned this Oct 11, 2023
@Jonas-Sander Jonas-Sander mentioned this issue Nov 5, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2023
@Jonas-Sander
Add support for private CloudFiles. (#1150)
bbd4a1a 
* `private` property will now be added to files by the client
* If a file is private the `FileSheet` will display "Privat (nur für
dich sichtbar)"

![grafik](https://github.com/SharezoneApp/sharezone-app/assets/29028262/07ee331e-f5bc-43d7-83ad-1645329ec0c7)


Linked PR: SharezoneApp/backend-mono#27

Closes #132
@nilsreichardt nilsreichardt moved this to Closed in Triage May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jonas-Sander Jonas-Sander

Labels
bug Something isn't working. feature: attachments Attachments are files that can be added to homeworks or information sheets. feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course.
Projects
Triage
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for private CloudFiles. SharezoneApp/sharezone-app
1 participant
@Jonas-Sander