Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for private CloudFiles. #1150

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Add support for private CloudFiles. #1150

merged 3 commits into from
Nov 6, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Nov 4, 2023 •
edited
Loading

  • private property will now be added to files by the client
  • If a file is private the FileSheet will display "Privat (nur für dich sichtbar)"
    grafik

Linked PR: https://github.com/SharezoneApp/backend-mono/pull/27

Closes #132

@github-actions github-actions bot added feature: homework feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. ui / ux feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. testing labels Nov 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 462a43b):

https://sharezone-test--pr1150-add-private-file-t359igi6.web.app

(expires Thu, 09 Nov 2023 11:19:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander marked this pull request as ready for review November 4, 2023 20:39
nilsreichardt
nilsreichardt approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander disabled auto-merge November 6, 2023 11:15
@Jonas-Sander
Copy link
Collaborator Author

I will merge after https://github.com/SharezoneApp/backend-mono/pull/27 is approved and deployed

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit bbd4a1a Nov 6, 2023
21 checks passed
@Jonas-Sander Jonas-Sander deleted the add-private-file branch November 6, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
feature: file-sharing Files can be shared inside Sharezone e.g. by uploading them in a file-sharing folder of a course. feature: homework feature: universal file features File features (downloading, preview, etc.) that are used by multiple Sharezone features. testing ui / ux
Projects
None yet
Milestone
No milestone
2 participants
@Jonas-Sander @nilsreichardt