Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A user should be able to view the events from the past. #242

Closed
nilsreichardt opened this issue May 18, 2022 · 0 comments · Fixed by #1042
Closed

A user should be able to view the events from the past. #242

nilsreichardt opened this issue May 18, 2022 · 0 comments · Fixed by #1042
Labels
enhancement New functionality that we agreed on to add in the future. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar).

Comments

@nilsreichardt
Copy link
Member

Description

Currently, it's only possible to view the calendar events from today or of the future. But sometimes it's helpful to view the events from the past. Possible use cases are:

  • You need to take a make-up exam (Klausur nachschreiben) and you want to view the topics of the exam
  • You want to view the topics of the last exams just for fun

Implementation

The implementation should be straightforward because we just need to change this query to isLessThanOrEqualTo:

sharezone-app/app/lib/util/api/timetableGateway.dart

Line 99 in 4c28345

.where('date', isGreaterThanOrEqualTo: startDate.toDateString)

@nilsreichardt nilsreichardt added enhancement New functionality that we agreed on to add in the future. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). labels May 18, 2022
@nilsreichardt nilsreichardt mentioned this issue Sep 20, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 24, 2023
@nilsreichardt
Add option to view past events for Sharezone Plus users (#1042)
460dba4 
## Description

This PR adds the feature to view the past events.

I haven't added lazy loading to avoid complexity. If this feature is
actually used, we can add lazy later.

## Demo

Unlocked:


https://github.com/SharezoneApp/sharezone-app/assets/24459435/8db4c9e4-e26b-4150-be42-96cfd32bf8e9

Not unlocked:

<img width="754" alt="image"
src="https://github.com/SharezoneApp/sharezone-app/assets/24459435/32133a70-2ed4-4429-a2e0-5f761d3248a1">

## Related Tickets

Closes #242
Closes #891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New functionality that we agreed on to add in the future. feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to view past events for Sharezone Plus users SharezoneApp/sharezone-app
1 participant
@nilsreichardt