Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to view past events for Sharezone Plus users #1042

Merged
merged 24 commits into from
Sep 24, 2023

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Sep 20, 2023

Description

This PR adds the feature to view the past events.

I haven't added lazy loading to avoid complexity. If this feature is actually used, we can add lazy later.

Demo

Unlocked:

Screen.Recording.2023-09-23.at.00.23.41.mov

Not unlocked:

image

Related Tickets

Closes #242
Closes #891

@github-actions github-actions bot added feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription labels Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Visit the preview URL for this PR (updated for commit d29cbfb):

https://sharezone-test--pr1042-add-option-to-view-p-iu2r0v58.web.app

(expires Wed, 27 Sep 2023 16:18:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@github-actions github-actions bot added ui / ux ui: light-mode ui: dark-mode feature: analytics Includes everything that is related to analytics and usage tracking labels Sep 22, 2023
@nilsreichardt nilsreichardt marked this pull request as ready for review September 22, 2023 23:18
@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 24, 2023
@nilsreichardt nilsreichardt removed this pull request from the merge queue due to a manual request Sep 24, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 24, 2023
Merged via the queue into main with commit 460dba4 Sep 24, 2023
@nilsreichardt nilsreichardt deleted the add-option-to-view-past-events branch September 24, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: analytics Includes everything that is related to analytics and usage tracking feature: sharezone plus Includes everything that is related to the Sharezone Plus subscription feature: timetable / calendar Includes anything regarding lessons (timetable) and events (calendar). testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to view past events A user should be able to view the events from the past.
2 participants