Going back to macos-12 for iOS integration tests to improve the performance dramatically
#1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsreichardt
changed the title
macos-12 for iOS integration tests to improve the performance dramatically
Jonas-Sander
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the issue why our build times for iOS integration tests went from 15 - 20 minutes to 60 - 100 minutes: it's
macos-13. Going back tomacos-12solves this issue. Invertase faced the same issue: firebase/flutterfire#11451.I tested it with 3 builds using
macos-12. All three only took 23 minutes:https://github.com/SharezoneApp/sharezone-app/actions/runs/6228178121/job/16904381314?pr=1012
However, using
macos-12has the problem thatmacos-12does not support Metal (flutter/flutter#126768), which is used by Impeller. So we have to disable Impeller for integration testing. This is not really great, because in production we use Impeller, and there could be a problem with Impeller in our application that is not tested. In the end, it's a trade-off. I think the probability that there is an issue with Impeller that is covered by our integration tests is very low, and having 120 minutes of integration tests really slows down development. So I would choose the option to disable Impeller for now.