Refactor some of the homework dialog code. #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature: homework
feature: timetable / calendar
Jonas-Sander
changed the title
Jonas-Sander
changed the title
|
Visit the preview URL for this PR (updated for commit 132b82f): https://sharezone-test--pr1112-homework-dialog-0jf6dt45.web.app (expires Sat, 07 Oct 2023 21:32:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
Continue refactoring the homework dialog (see #1112) * Add `loadCloudFiles` to `HomeworkDialogApi` * Make attributes of `HomeworkDialogApi` private * Add empty state and edit state widget tests (can probably be replaced by golden tests in the future) * Add widget that inputs data and compares it to the `UserInput`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits up the "is private" and "are submissions enabled" parts of the homework dialog into bloc-agnostic (
xyzBasewidgets) and composing widgets.Doing this should make changing the homework dialog easier in the future. Also if we ever decide to break the edit and create dialog up into different widgets we need to use the bloc-agnostic base widgets anyways.
Additionally I moved the
NextLessonCalculatorout of theHomeworkDialogApiand made its attributes private. This should ease mocking in future widget tests of the homework dialog.