Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FVM #146

Merged
merged 6 commits into from
Apr 23, 2022
Merged

Use FVM #146

merged 6 commits into from
Apr 23, 2022

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Apr 13, 2022

Description

This PR introduces the use of FVM. FVM allows to us have a SOT of our Flutter version. Therefore, it's easier to keep the same Flutter version across different developers. Additionally, we can use in CI/CD the same Flutter version in every workflow.

Additional setup

The use of FVM require additionally setup steps for a new developer:

# Install FVM
dart pub global activate fvm

# Install Flutter version
fvm install

How to change the Flutter version

  1. Change the version in .fvm/fvm_config.json
  2. Run fvm install

Related Tickets

Closes #144

@@ -0,0 +1,4 @@
{
"flutterSdkVersion": "2.5.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the Flutter version in a seperate PR

// IDE tooling.
//
// Source: https://fvm.app/docs/getting_started/configuration#option-1---automatic-switching-recommended
"dart.flutterSdkPath": ".fvm/flutter_sdk",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android Studio users need to set up FVM for themselves in Android Studio, because I think in Android Studio isn't something like settings.json which can commit to git (I think the .idea/workspace.xml contains also information about the local machine): https://fvm.app/docs/getting_started/configuration/#android-studio

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info, then we should add this to our setup documentation doc as well

@github-actions
Copy link

github-actions bot commented Apr 13, 2022

Visit the preview URL for this PR (updated for commit 59f8bea):

https://sharezone-test--pr146-fvm-bz5ljq0w.web.app

(expires Sat, 30 Apr 2022 14:43:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@nilsreichardt
Copy link
Member Author

@Jonas-Sander Are the setup steps part of the CONTRIBUTION.md (#28)?

@Jonas-Sander
Copy link
Collaborator

I guess so. If you create it then don't forget to link to it from the README.md

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I would like the setup documentation added via this PR as well

@nilsreichardt
Copy link
Member Author

@Jonas-Sander I added a new section to CONTRIBUTIN.md. Is this enough documentation, or should we add more?

@Jonas-Sander
Copy link
Collaborator

@Jonas-Sander I added a new section to CONTRIBUTIN.md. Is this enough documentation, or should we add more?

LGTM like this

@nilsreichardt nilsreichardt merged commit 434d0cd into main Apr 23, 2022
@nilsreichardt nilsreichardt deleted the fvm branch April 23, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a single-source-of-truth for the flutter version that is used by developers and the CI/CD system.
2 participants