-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FVM #146
Use FVM #146
Conversation
@@ -0,0 +1,4 @@ | |||
{ | |||
"flutterSdkVersion": "2.5.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the Flutter version in a seperate PR
// IDE tooling. | ||
// | ||
// Source: https://fvm.app/docs/getting_started/configuration#option-1---automatic-switching-recommended | ||
"dart.flutterSdkPath": ".fvm/flutter_sdk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android Studio users need to set up FVM for themselves in Android Studio, because I think in Android Studio isn't something like settings.json
which can commit to git (I think the .idea/workspace.xml
contains also information about the local machine): https://fvm.app/docs/getting_started/configuration/#android-studio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info, then we should add this to our setup documentation doc as well
Visit the preview URL for this PR (updated for commit 59f8bea): https://sharezone-test--pr146-fvm-bz5ljq0w.web.app (expires Sat, 30 Apr 2022 14:43:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
@Jonas-Sander Are the setup steps part of the |
I guess so. If you create it then don't forget to link to it from the README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I would like the setup documentation added via this PR as well
@Jonas-Sander I added a new section to |
LGTM like this |
Description
This PR introduces the use of FVM. FVM allows to us have a SOT of our Flutter version. Therefore, it's easier to keep the same Flutter version across different developers. Additionally, we can use in CI/CD the same Flutter version in every workflow.
Additional setup
The use of FVM require additionally setup steps for a new developer:
How to change the Flutter version
.fvm/fvm_config.json
fvm install
Related Tickets
Closes #144