Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first section to CONTRIBUTING.md #147

Merged
merged 15 commits into from
Apr 18, 2022
Merged

Add first section to CONTRIBUTING.md #147

merged 15 commits into from
Apr 18, 2022

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Apr 18, 2022

This PR adds a first part (How to set up your development environment) of the CONTRIBUTING.md. Therefore, we are able to add more sections (mentioned in#28) later.

After merging this PR, I can add the needed documentation of #146.

Part of #28

@github-actions
Copy link

github-actions bot commented Apr 18, 2022

Visit the preview URL for this PR (updated for commit 7e7536f):

https://sharezone-test--pr147-contributing-md-7j9u1ueq.web.app

(expires Mon, 25 Apr 2022 18:10:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Jonas Sander <[email protected]>
CONTRIBUTING.md Outdated Show resolved Hide resolved
nilsreichardt and others added 2 commits April 18, 2022 17:22
Co-authored-by: Jonas Sander <[email protected]>
Co-authored-by: Jonas Sander <[email protected]>
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions. LGTM.

@nilsreichardt
Copy link
Member Author

@Jonas-Sander Can you review again?

You can just use the option "Show changes since your last review"

image

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See last comment, everything else LGTM

CONTRIBUTING.md Outdated Show resolved Hide resolved
@nilsreichardt nilsreichardt merged commit 724a11f into main Apr 18, 2022
@nilsreichardt nilsreichardt deleted the contributing-md branch April 18, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants