-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first section to CONTRIBUTING.md
#147
Conversation
Visit the preview URL for this PR (updated for commit 7e7536f): https://sharezone-test--pr147-contributing-md-7j9u1ueq.web.app (expires Mon, 25 Apr 2022 18:10:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Co-authored-by: Jonas Sander <[email protected]>
Co-authored-by: Jonas Sander <[email protected]>
Co-authored-by: Jonas Sander <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some suggestions. LGTM.
@Jonas-Sander Can you review again? You can just use the option "Show changes since your last review" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See last comment, everything else LGTM
This PR adds a first part (
How to set up your development environment
) of theCONTRIBUTING.md
. Therefore, we are able to add more sections (mentioned in#28) later.After merging this PR, I can add the needed documentation of #146.
Part of #28