Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use adaptive platform density for privacy policy. #1691

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Jul 25, 2024

With 219bea1 we started to use VisualDensitySetting.standard() on all platforms instead of VisualDensitySetting.adaptivePlatformDensity(). Since the latter is better for the privacy policy UI on desktops we override it on this page.

Before After
grafik grafik

@github-actions github-actions bot added the legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. label Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Visit the preview URL for this PR (updated for commit 4abc1cb):

https://sharezone-test--pr1691-use-adaptive-density-u41gm51q.web.app

(expires Sun, 28 Jul 2024 14:29:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander marked this pull request as ready for review July 25, 2024 11:23
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/lib/legal/privacy_policy/privacy_policy_page.dart Outdated Show resolved Hide resolved
@Jonas-Sander Jonas-Sander enabled auto-merge July 25, 2024 14:25
@Jonas-Sander Jonas-Sander added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 31326e9 Jul 25, 2024
37 checks passed
@Jonas-Sander Jonas-Sander deleted the use-adaptive-density-for-privacy-policy branch July 25, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legal Regarding Licenses, Policy updates, Warnings to users (that might cause trouble if not there) etc. ui / ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants