Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use adaptive platform density for privacy policy. #1691

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Use adaptive platform density for privacy policy. #1691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c5fd6a
Use adaptive platform density for privacy policy.
Jonas-Sander Jul 25, 2024
4abc1cb
Update app/lib/legal/privacy_policy/privacy_policy_page.dart
Jonas-Sander Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion app/lib/legal/privacy_policy/privacy_policy_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,19 @@ class PrivacyPolicyPage extends StatelessWidget {
create: (context) {
final themeSettings =
Provider.of<ThemeSettings>(context, listen: false);
return _createPrivacyPolicyThemeSettings(
final newSettings = _createPrivacyPolicyThemeSettings(
context, themeSettings, config);
// As of this writing, we always use
// VisualDensitySetting.standard() instead of
// VisualDensitySetting.adaptivePlatformDensity() on all
// platforms. This may make sense for the general UI, but for
// the privacy policy page it is much better to use the adaptive
// spacing. This will make the TOC tiles more compact for
// desktop (since users will most likely be using a mouse there)
// and more spread out for touch users.
newSettings.visualDensitySetting =
VisualDensitySetting.adaptivePlatformDensity();
return newSettings;
},
),
Provider<DocumentController>(
Expand Down
Loading