Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed implicit-casts to false in analysis-options.yaml for /app #39

Merged
merged 0 commits into from
Sep 16, 2021

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Sep 16, 2021

In the Future I want to more or less use the same analysis-options.yaml for all packages (see #37).

The most important first step is to change implicit-casts to true as this is the most work for changing to a new analysis-options.yaml in the future.

@Jonas-Sander
Copy link
Collaborator Author

@nilsreichardt Most fixes are prettey "stupid" so idk if you need to look through all of these. That said I haven't tested manually yet.

Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/lib/pages/homework/homework_dialog.dart Outdated Show resolved Hide resolved
@Jonas-Sander Jonas-Sander merged this pull request into main Sep 16, 2021
@Jonas-Sander Jonas-Sander deleted the implicit-casts-false branch September 16, 2021 21:00
nilsreichardt added a commit that referenced this pull request Sep 24, 2023
A shorter and nicer link for our marketing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants