Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed submissions feature discovery. #40

Merged
merged 0 commits into from
Sep 16, 2021

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Sep 16, 2021

The submission feature is not new anymore and from my experimentations the feature discovery won't be shown anymore anyhow.
Basically it is dead code, which is why I want to remove it.

@Jonas-Sander
Copy link
Collaborator Author

This should solve the discussion in #39 as the problem will just be removed ;)

Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander merged this pull request into main Sep 16, 2021
@Jonas-Sander Jonas-Sander deleted the remove-submissions-feature-discovery branch September 16, 2021 20:39
nilsreichardt added a commit that referenced this pull request Sep 24, 2023
Node 12 is deprecated for GitHub Actions. This is the reason why we are
getting a warning from GitHub:

> Node.js 12 actions are deprecated. Please update the following actions
to use Node.js 16: actions/checkout@v2. For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

This PR updates `actions/checkout` from v2 to v3 which should fix the
problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants