Split main.yml into app_ci.yml and license.yml to use path filters
#400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7feae8d.
|
Visit the preview URL for this PR (updated for commit 7225bfe): https://sharezone-test--pr400-exclude-paths-for-al-dwx51m6v.web.app (expires Mon, 06 Mar 2023 23:30:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
approved these changes
Feb 27, 2023
This was referenced Feb 28, 2023
nilsreichardt
added a commit
that referenced
this pull request
Mar 7, 2023
This PR adds a CI for our CLI because with #400 the CLI was excluded from our CI. I have not added the path for our CLI to our `app_ci.yml` because otherwise we would also trigger the integration test and the CI for our app, which is not needed when only modifying our CLI. This makes our CI faster and we don't need to use a `macos` machine for our `test` job here. A side effect is currently that we also run the analyze and test step for our CLI in our app CI. However, I think that is not a big problem (in the future we could add a `exclude-package` argument to the `sz analyze` and `sz test` command to prevent this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we had all CI workflow in one
main.ymlfile. The disadvantage: we always triggered the unit tests, analyze jobs, integration tests, web preview, etc. even when only made a change in.mdfile -> always long CI times.To be able to only run the app workflow for app changes, we need to define the triggers on a file level. Therefore, we needed to split the workflows in separated file because sometimes we want to run workflow always (like the license check workflow) and some action only when the app changed (the
analyzejob).We have now these file structures:
app_ci.yml:analyze,test,web-preview,ios-integration-test,android-integration-testlicense.yml:check-files-licence-headers