Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App workflows waiting for every when they are not triggered #403

Closed
nilsreichardt opened this issue Feb 28, 2023 · 0 comments · Fixed by #404
Closed

App workflows waiting for every when they are not triggered #403

nilsreichardt opened this issue Feb 28, 2023 · 0 comments · Fixed by #404
Assignees
@nilsreichardt
Labels
ci/cd

Comments

@nilsreichardt
Copy link
Member

nilsreichardt commented Feb 28, 2023 •
edited
Loading

image

With #400 we only trigger the app workflows when there was an app change. However, when there was not an app change, the required workflows are not triggered and it's impossible to merge the PR.
@nilsreichardt nilsreichardt self-assigned this Feb 28, 2023
@nilsreichardt nilsreichardt mentioned this issue Feb 28, 2023
Merged
nilsreichardt added a commit that referenced this issue Mar 2, 2023
@nilsreichardt
Add Fallback App CI (#404)
9d960f4 
![image](https://user-images.githubusercontent.com/24459435/221893313-7aa00dea-a22d-4280-a05f-242586596c12.png)


A workaround for GitHub Actions jobs that required and based on a path.

Currently, it's not possible to set a GitHub Action to required which is
based on path changes. The reason for this that the action is not
executed when the action does not match the paths. Therefore, merging
will be blocked.

A workaround is to have a job which the same name. 

See:
github/docs@4364076

Closes #403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilsreichardt nilsreichardt

Labels
ci/cd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Fallback App CI SharezoneApp/sharezone-app
1 participant
@nilsreichardt