Add Fallback App CI #404
Merged
Add Fallback App CI #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 05efa7b): https://sharezone-test--pr404-add-fallback-ci-pubnsn5g.web.app (expires Thu, 09 Mar 2023 22:13:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
|
@Jonas-Sander Could you also review this PR because this blocks #407 |
Jonas-Sander
approved these changes
Mar 2, 2023
|
btw we need to execute the jobs when changing the sharezone cli folder aswell (since some call the functions in there) |
Good point, I'll make a new PR for this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround for GitHub Actions jobs that required and based on a path.
Currently, it's not possible to set a GitHub Action to required which is based on path changes. The reason for this that the action is not executed when the action does not match the paths. Therefore, merging will be blocked.
A workaround is to have a job which the same name.
See: github/docs@4364076
Closes #403