Fix dark theme dialog colors. #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android picking only reminder times in an half-hour interval was broken. Instead a user could pick any time. By using `package:interval_time_picker` this issue is now fixed an users can again only pick reminder times in an half-hour interval.
By using `ColorScheme.fromSwatch().copyWith(...)` the `ColorScheme` was tailored to light-mode which caused some dialogs to be displayed in the wrong colors when using dark mode. Specifying the `Brightness` inside `ColorScheme.fromSeed` fixed this issue.
github-actions
bot
added
dependencies
|
Visit the preview URL for this PR (updated for commit 3ad69f7): https://sharezone-test--pr569-fix-dark-theme-dialo-iteuv403.web.app (expires Sun, 16 Apr 2023 21:39:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
|
This PR also fixes #384 |
|
Wrong in the PR description (you need to swap the images) |
nilsreichardt
requested changes
Apr 6, 2023
github-actions
bot
added
the
feature: authentification
Jonas-Sander
commented
Apr 9, 2023
| @@ -72,6 +72,7 @@ class SignInWithAppleButton extends StatelessWidget { | |||
| child: Icon( | |||
| FontAwesomeIcons.apple, | |||
| size: 26, | |||
| color: Colors.white, | |||
There was a problem hiding this comment.
As you can see in your last screen shot the icon was not completely white. I didn't find see this for the other icons in the app though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
ColorScheme.fromSwatch().copyWith(...)theColorSchemewas tailored to light-mode which caused some dialogs to be displayed in the wrong colors when using dark mode.Specifying the
BrightnessinsideColorScheme.fromSeedfixed this issue.Fixes #167
Fixes #168
Fixes #169
Fixes #384
Fixes #496