Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bloc library in hausaufgabenheft_logik package. #738

Merged
merged 26 commits into from
Aug 17, 2023
Merged

Upgrade bloc library in hausaufgabenheft_logik package. #738

merged 26 commits into from
Aug 17, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Aug 16, 2023 •
edited
Loading

Upgrade the bloc package from ^4.0.0 to ^8.1.2.
This enables us to make the hausaufgabenheft_logik package null-safe afterwards (#191).

Note: Before there was an abstract "interface" for some blocs in our code, which I removed because of class types issues (Bloc was Stream before but isn't after upgrading) and also because it's unnecessary. Thus I also renamed some bloc files which git seems to interpret as deleting old bloc files and creating new ones.

Closes #729

@Jonas-Sander
Export event and state in bloc files and remove abstract bloc file.
98ad196
@Jonas-Sander
Remove abstract CompletedHomeworksViewBloc.
3f521bc
@Jonas-Sander
Remove abstract LazyLoadingCompletedHomeworksBloc.
badca19
@Jonas-Sander
Rename CompletedHomeworksViewBloc file.
9c0fc34
@Jonas-Sander
Rename LazyLoadingCompletedHomeworksBloc file.
207b926
@Jonas-Sander
Update bloc version to ^8.1.2
e63b743
@Jonas-Sander
Prefix bloc_base BlocBase because of collision with BlocBase from blo…
922b00e 
…c package.
@Jonas-Sander
Replace initialState via super parameter.
428b787
@Jonas-Sander
Remove mapEventToState in OpenHomeworksViewBloc.
2ccd406
@Jonas-Sander
Remove mapEventToState in TeacherHomeworkPageBloc.
06affbc
@Jonas-Sander
Remove mapEventToState in CompletedHomeworksViewBloc.
303ba6e
@Jonas-Sander
Remove mapEventToState in HomeworkPageBloc.
72689b8
@Jonas-Sander
Remove mapEventToState in LazyLoadingCompletedHomeworksBloc.
936282a
@Jonas-Sander
Remove mapEventToState in OpenHomeworkListBloc.
272e437
@Jonas-Sander
Remove mapEventToState in MockOpenHomeworkListBloc.
aea2980
@Jonas-Sander
Replace BlocObserver
7857d20
@Jonas-Sander
Fix lints.
702213e
@Jonas-Sander
Fix bloc.stream in app
6bf5faa
@Jonas-Sander
Remove mapEventToState of MockTeacherHomeworkPageBloc.
08411ed
@Jonas-Sander
Fix tests in homework_page_bloc_test.dart
071a439
@Jonas-Sander
Fix tests in teacher_homework_page_test.dart
c6f375a
@Jonas-Sander Jonas-Sander linked an issue Aug 16, 2023 that may be closed by this pull request
Upgrade bloc library in hausaufgabenheft_logik package. #729
Closed
@github-actions github-actions bot added feature: homework testing user: teacher user: pupil / student dependencies Changing, updating, adding or removing one or more dependencies. labels Aug 16, 2023
@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit c04ecf5):

https://sharezone-test--pr738-729-upgrade-bloc-lib-a53m8rxi.web.app

(expires Thu, 24 Aug 2023 17:25:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

nilsreichardt
nilsreichardt reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. label Aug 17, 2023
@Jonas-Sander Jonas-Sander enabled auto-merge August 17, 2023 17:21
nilsreichardt
nilsreichardt approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Aug 17, 2023
@Jonas-Sander Jonas-Sander mentioned this pull request Aug 17, 2023
Merged
Merged via the queue into main with commit c642a78 Aug 17, 2023
@Jonas-Sander Jonas-Sander deleted the 729-upgrade-bloc-library-in-hausaufgabenheft_logik-package branch August 17, 2023 19:19
nilsreichardt pushed a commit that referenced this pull request Aug 18, 2023
@Jonas-Sander
Migrate hausaufgabenheft_logik and `firebase_hausaufgabenheft_logik…
e6d8c5b 
…` to null safety. (#744)

Requires #743 
Requires #738 

Closes #191 
Closes #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
dependencies Changing, updating, adding or removing one or more dependencies. feature: homework feature: homework-submissions Submissions can be toggled for homeworks so that pupils can upload their solutions for the teacher. testing user: pupil / student user: teacher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade bloc library in hausaufgabenheft_logik package.
2 participants
@Jonas-Sander @nilsreichardt