Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key_value_store nullability. #743

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix key_value_store nullability. #743

merged 1 commit into from
Aug 17, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

No description provided.

nilsreichardt
nilsreichardt approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander enabled auto-merge August 17, 2023 18:37
@Jonas-Sander Jonas-Sander mentioned this pull request Aug 17, 2023
Merged
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 41e19da):

https://sharezone-test--pr743-fix-key-value-store-lms47rvv.web.app

(expires Thu, 24 Aug 2023 18:39:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Aug 17, 2023
@nilsreichardt nilsreichardt removed this pull request from the merge queue due to a manual request Aug 17, 2023
@nilsreichardt nilsreichardt added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit 142fef1 Aug 17, 2023
@nilsreichardt nilsreichardt deleted the fix-key_value_store-nullability branch August 17, 2023 21:49
nilsreichardt pushed a commit that referenced this pull request Aug 18, 2023
@Jonas-Sander
Migrate hausaufgabenheft_logik and `firebase_hausaufgabenheft_logik…
e6d8c5b 
…` to null safety. (#744)

Requires #743 
Requires #738 

Closes #191 
Closes #194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsreichardt nilsreichardt nilsreichardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonas-Sander @nilsreichardt