Read Google Play credentials from env instead of from file for sz deploy android
#947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 8c06e04): https://sharezone-test--pr947-sz-deploy-android-en-i2et2anz.web.app (expires Sat, 16 Sep 2023 09:01:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
Jonas-Sander
approved these changes
Sep 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the env
GCLOUD_SERVICE_ACCOUNT_CREDENTIALSinstead of the file. This simplifies the setup because the creation ofgoogle-play-gserviceaccount.jsonis not needed anymore andGCLOUD_SERVICE_ACCOUNT_CREDENTIALSis anyway used by the Codemagic CLI tools.