Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Google Play credentials from env instead of from file for sz deploy android #947

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Read Google Play credentials from env instead of from file for sz deploy android #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/beta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,18 +192,10 @@ jobs:
fvm flutter pub global activate --source path "$CI_CD_DART_SCRIPTS_PACKAGE_PATH"
echo $(pwd)/bin >> $GITHUB_PATH

- name: Set up Google Play credentials for Fastlane
env:
GOOGLE_PLAY_SERVICE_ACCOUNT_JSON: ${{ secrets.SHAREZONE_GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}
working-directory: app
run: |
mkdir private_keys && cd private_keys
echo $GOOGLE_PLAY_SERVICE_ACCOUNT_JSON > google-play-gserviceaccount.json

- name: Deploy
env:
# Export the Google Play service account credentials as an environment
# variable for Codemagic CLI tools.
# variable for Sharezone Repo CLI.
GCLOUD_SERVICE_ACCOUNT_CREDENTIALS: ${{ secrets.SHAREZONE_GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}
run: |
# When passing the changelog from GitHub Actions to the CLI, the line
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/stable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,18 +211,10 @@ jobs:
fvm flutter pub global activate --source path "$CI_CD_DART_SCRIPTS_PACKAGE_PATH"
echo $(pwd)/bin >> $GITHUB_PATH

- name: Set up Google Play credentials for Fastlane
env:
GOOGLE_PLAY_SERVICE_ACCOUNT_JSON: ${{ secrets.SHAREZONE_GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}
working-directory: app
run: |
mkdir private_keys && cd private_keys
echo $GOOGLE_PLAY_SERVICE_ACCOUNT_JSON > google-play-gserviceaccount.json

- name: Deploy
env:
# Export the Google Play service account credentials as an environment
# variable for Codemagic CLI tools.
# variable for Sharezone Repo CLI.
GCLOUD_SERVICE_ACCOUNT_CREDENTIALS: ${{ secrets.SHAREZONE_GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}
run: |
# When passing the changelog from GitHub Actions to the CLI, the line
Expand Down
2 changes: 1 addition & 1 deletion app/android/fastlane/Appfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
json_key_file("../private_keys/google-play-gserviceaccount.json")
json_key_data_raw(ENV['GCLOUD_SERVICE_ACCOUNT_CREDENTIALS'])
package_name("de.codingbrain.sharezone")