[BFCL] Bug Fix parse_nested_value function for model_handler utils #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuanzhiMao
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Failed on the following test:
x = "[foo(a=1, b={'a': 1, 'b': 'hello'}), bar(c=3, d={'a': 1, 'b': foo(c=1, d=2)}), baz(e=f(x=1, y=2))]"
print(default_decode_execute_prompting(x))
# Expect ["foo(a=1, b={'a': 1, 'b': 'hello'})", 'bar(c=3, d={'a': 1, 'b': foo(c=1, d=2)})', 'baz(e=f(x=1, y=2))']
# But got ["foo(a=1, b={a=1, b='hello'})", 'bar(c=3, d={a=1, b=foo(c=1, d=2)})', 'baz(e=f(x=1, y=2))']
|
@HuanzhiMao Thank you for catching. Should be fixed in the latest commit. |
HuanzhiMao
approved these changes
Sep 24, 2024
ShishirPatil
approved these changes
Sep 25, 2024
dyang415
pushed a commit
to empower-ai/gorilla
that referenced
this pull request
Sep 30, 2024
…hishirPatil#660) In the parse_nested_value function, added a check to determine whether we are dealing with another function call or if its a regular dictionary. Previous version of the code incorrectly assumed that this was always a function call and did not consider the case where the function argument is a dictionary. Fix ShishirPatil#652 --------- Co-authored-by: Huanzhi (Hans) Mao <[email protected]>
ShishirPatil
pushed a commit
that referenced
this pull request
Oct 21, 2024
This PR updates the leaderboard to reflect the change in score due to the following PR merge: 1. #660 2. #661 3. #683 4. #679 5. #708 6. #709 7. #701 8. #657 9. #658 10. #640 11. #653 12. #642 13. #696 14. #667 Close #662. Note: Some models (like `firefunction`, `functionary`, `microsoft/phi`)are not included in this leaderboard update because we don't have all the entries generated. We will add them back once we get the full result generated.
VishnuSuresh27
added a commit
to VishnuSuresh27/gorilla
that referenced
this pull request
Nov 11, 2024
…hishirPatil#660) In the parse_nested_value function, added a check to determine whether we are dealing with another function call or if its a regular dictionary. Previous version of the code incorrectly assumed that this was always a function call and did not consider the case where the function argument is a dictionary. Fix ShishirPatil#652 --------- Co-authored-by: Huanzhi (Hans) Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the parse_nested_value function, added a check to determine whether we are dealing with another function call or if its a regular dictionary. Previous version of the code incorrectly assumed that this was always a function call and did not consider the case where the function argument is a dictionary.
Fix #652