Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Add Gemma-2 models #696

Merged
merged 5 commits into from
Oct 17, 2024
Merged

[BFCL] Add Gemma-2 models #696

merged 5 commits into from
Oct 17, 2024

Conversation

jacovkim
Copy link
Contributor

BFCL currently don't support gemma2-2b. Added handler to handler map using GemmaHandler.

@HuanzhiMao
Copy link
Collaborator

Does the old Gemma handler still work for Gemma 2?

@jacovkim
Copy link
Contributor Author

Yes, the format of the prompt is same across two versions.

Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jacovkim and welcome!
LGTM

@HuanzhiMao HuanzhiMao changed the title Added metadata for Gemma-2 models [BFCL] Add Gemma-2 models Oct 14, 2024
@HuanzhiMao HuanzhiMao added the BFCL-New Model Add New Model to BFCL label Oct 14, 2024
@HuanzhiMao HuanzhiMao merged commit fec21c1 into ShishirPatil:main Oct 17, 2024
ShishirPatil pushed a commit that referenced this pull request Oct 21, 2024
This PR updates the leaderboard to reflect the change in score due to
the following PR merge:

1. #660 
2. #661
3. #683
4. #679
5. #708 
6. #709
7. #701
8. #657 
9. #658 
10. #640 
11. #653
12. #642 
13. #696 
14. #667

Close #662.

Note: Some models (like `firefunction`, `functionary`,
`microsoft/phi`)are not included in this leaderboard update because we
don't have all the entries generated. We will add them back once we get
the full result generated.
VishnuSuresh27 pushed a commit to VishnuSuresh27/gorilla that referenced this pull request Nov 11, 2024
BFCL currently don't support gemma2 models. Added handler to handler map
using GemmaHandler.

---------

Co-authored-by: Huanzhi Mao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFCL-New Model Add New Model to BFCL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants