Skip to content

Commit

Permalink
chore: delete unused code (appsmithorg#36461)
Browse files Browse the repository at this point in the history
## Description
The second round of deleting unused files, `.ts` were added to the
check.

[Related EE PR](appsmithorg/appsmith-ee#5205)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10991435044>
> Commit: 7cfbcb9
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10991435044&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 23 Sep 2024 10:51:02 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Expanded project file scope to include JavaScript files alongside
TypeScript files.
- **Bug Fixes**
- Removed obsolete functions and constants related to help, tour, and
API functionalities, improving overall code clarity and maintenance.
- **Chores**
- Deleted several unused files and constants across various components,
enhancing project organization and reducing clutter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
KelvinOm authored Sep 23, 2024
1 parent 8fe96c9 commit cd3472a
Show file tree
Hide file tree
Showing 57 changed files with 12 additions and 6,032 deletions.
14 changes: 12 additions & 2 deletions app/client/knip.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"entry": ["src/index.tsx"],
"project": ["src/**/*.tsx"],
"project": ["src/**/*.{tsx,ts,js}"],
"ignore": [
"packages/**/stories/**",
"packages/**/chromatic/**",
Expand All @@ -9,6 +9,16 @@
"packages/rts/build.js",
"packages/design-system/ads/src/Documentation/**",
"src/components/designSystems/blueprintjs/**",
"packages/design-system/ads/plopfile.mjs"
"packages/design-system/ads/plopfile.mjs",
"src/plugins/Linting/**",
"src/ee/plugins/Linting/**",
"src/ce/plugins/Linting/**",
"src/workers/Evaluation/**",
"src/widgets/ExternalWidget/component/script.js",
"src/widgets/ListWidgetV2/widget/derived.js",
"src/workers/Tern/tern.worker.ts",
"src/widgets/CustomWidget/component/appsmithConsole.js",
"src/serviceWorker.ts",
"src/ee/utils/serviceWorkerUtils.ts"
]
}
14 changes: 0 additions & 14 deletions app/client/src/actions/helpActions.ts

This file was deleted.

22 changes: 0 additions & 22 deletions app/client/src/actions/tourActions.ts

This file was deleted.

25 changes: 0 additions & 25 deletions app/client/src/api/SaasApi.ts

This file was deleted.

24 changes: 0 additions & 24 deletions app/client/src/assets/icons/blueprintjs/svgo.config.js

This file was deleted.

15 changes: 0 additions & 15 deletions app/client/src/ce/actions/auditLogsAction.ts

This file was deleted.

12 changes: 0 additions & 12 deletions app/client/src/ce/api/GitExtendedApi.ts

This file was deleted.

230 changes: 0 additions & 230 deletions app/client/src/ce/entities/DataTree/actionTriggers.ts

This file was deleted.

3 changes: 0 additions & 3 deletions app/client/src/ce/mocks/handlers.ts

This file was deleted.

Loading

0 comments on commit cd3472a

Please sign in to comment.